Add a defaultTryTimeout config parameter and use it for the try method. #7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a previous condition where we used the same 90 seconds timeout for finding elements and for the test to complete. The problem with that was if it failed to find an element the test would timeout first and you couldn't tell which element it failed to find.
That was fixed by adding a 10 second defaultFindTimeout.
But the next problem was that the "try" was calling tryForTime with that same 10 second defaultFindTimeout. And since try and tryForTime most often contain "find"s, we have to have a longer timeout for them. I picked 40 seconds.