Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use inclusive language for server.compression config #71625

Closed
wants to merge 1 commit into from
Closed

use inclusive language for server.compression config #71625

wants to merge 1 commit into from

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jul 14, 2020 •
edited
Loading

Summary

Part of #71398

Rename server.compression.referrerWhitelist config property to server.compression.referrerAllowlist

Checklist

@streamich streamich mentioned this pull request Jul 14, 2020
Closed
21 tasks
pgayvallet
pgayvallet commented Jul 14, 2020
View reviewed changes
src/core/server/http/http_config.ts
Comment on lines -81 to -83
compression: schema.object({
enabled: schema.boolean({ defaultValue: true }),
referrerWhitelist: schema.maybe(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is a mess because I had to extract the schema to its own var to add deprecations, but the only real change within the schema is here.

@pgayvallet pgayvallet added v7.10.0 v8.0.0 Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes labels Jul 14, 2020
@pgayvallet pgayvallet added release_note:deprecation and removed release_note:skip Skip the PR/issue when compiling release notes labels Jul 14, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review July 14, 2020 13:59
@pgayvallet pgayvallet requested a review from a team as a code owner July 14, 2020 13:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor Author

Closing - see #71398 (comment)

@pgayvallet pgayvallet closed this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdover joshdover joshdover approved these changes

Assignees
No one assigned
Labels
release_note:deprecation Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgayvallet @kibanamachine @elasticmachine @joshdover