-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node] Bump node.js to 4.4.4 #7148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will get VM's up and begin testing this today. |
Test is running, will report back in 24 hours. |
How's it looking? |
The average memory usage is a little higher, but the max is consistent to that of 4.3.2.. I have not had an OOM on the 2GB VM. LGTM |
@tylersmalley And your test was using SSL? |
Awesome, thanks. |
epixa
added a commit
that referenced
this pull request
May 10, 2016
--------- **Commit 1:** [node] Bump node.js to 4.4.4 * Original sha: 470404f * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-06T18:31:36Z
elastic-jasper
added a commit
that referenced
this pull request
May 10, 2016
--------- **Commit 1:** [node] Bump node.js to 4.4.4 * Original sha: 470404f * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-06T18:31:36Z
epixa
pushed a commit
to epixa/kibana
that referenced
this pull request
May 11, 2016
--------- **Commit 1:** [node] Bump node.js to 4.4.4 * Original sha: 470404f * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-06T18:31:36Z
epixa
added a commit
to epixa/kibana
that referenced
this pull request
May 11, 2016
--------- **Commit 1:** [node] Bump node.js to 4.4.4 * Original sha: 470404f * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-06T18:31:36Z ------------------------------- **Backported based on diff from PR elastic#7164**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/en/blog/release/v4.4.4/