-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Graph] Ensure inclusive language #71416
Conversation
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, thx for making Graph more inclusive 👍 , tested locally in Chrome, Firefox, blocking nodes works. Didn't test the migration, but looks good to me code wise.
Thanks for testing @kertal I updated the sample data as well, so if you installed while on this PR, it wouldn't test the migration, but if you installed it earlier than this would indeed validate the migration worked. |
was installed before, so it was migrated |
Part of #71398
Renames blacklist to blocklist in code. The interface already used the "blocklist" term, this is just making the code consistent. I'm aware we use "deny-list" in other places, but as we went with "blocklist" already, IMHO it makes sense to just stick with it.
This also adds a migration to rename the similar named key in the saved object.
As a side effect this also renames another occurrence in the timelion docs.