Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE support in functional tests #71285

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

dmlemeshko
Copy link
Member

Since 7.9 we no longer support Internet Explorer browser and it is a good chance to do the cleanup in FTR services/tests.

@dmlemeshko dmlemeshko added Team:QA Team label for QA Team v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 9, 2020
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending passing Jenkins
Re: https://github.com/elastic/dev/issues/1343

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko marked this pull request as ready for review July 9, 2020 19:51
@dmlemeshko dmlemeshko requested review from a team as code owners July 9, 2020 19:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit 633968e into elastic:master Jul 9, 2020
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 9, 2020
* [ftr] remove ie support

* remove ie integration tests config
# Conflicts:
#	test/functional/config.ie.js
#	test/functional/services/remote/remote.ts
dmlemeshko added a commit that referenced this pull request Jul 10, 2020
* Remove IE support in functional tests (#71285)

* [ftr] remove ie support

* remove ie integration tests config
# Conflicts:
#	test/functional/config.ie.js
#	test/functional/services/remote/remote.ts

* fix eslint errors

* [services/remote/webdriver] fix eslint error (#71346)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@dmlemeshko dmlemeshko deleted the ftr/remove-ie-support branch January 31, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants