Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENDPOINT] Fixing the consistency of util bar in endpoints and policies pages. #71133

Merged
merged 1 commit into from
Jul 9, 2020
Merged

[ENDPOINT] Fixing the consistency of util bar in endpoints and policies pages. #71133

merged 1 commit into from
Jul 9, 2020
+8 −7

Conversation

efreeti
Copy link
Contributor

@efreeti efreeti commented Jul 8, 2020 •
edited
Loading

Summary

Made items count util bar consistent between endpoints and policies pages.

Policies page:
Policies

Endpoints page:
Endpoints

@efreeti efreeti added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.9.0 labels Jul 8, 2020
@efreeti efreeti requested review from a team as code owners July 8, 2020 17:50
@efreeti efreeti self-assigned this Jul 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@kevinlog
Copy link
Contributor

kevinlog commented Jul 8, 2020

@efreeti could you add a screenshot of the updated page to the PR description?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@efreeti
Copy link
Contributor Author

efreeti commented Jul 9, 2020

@efreeti could you add a screenshot of the updated page to the PR description?

Added

kevinlog
kevinlog approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

paul-tavares
paul-tavares approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚀

@efreeti efreeti merged commit 8574a92 into elastic:master Jul 9, 2020
@efreeti efreeti deleted the efreeti/task_emt_561_utility_bar_consistency branch July 9, 2020 16:50
@kevinlog kevinlog mentioned this pull request Jul 9, 2020
Merged
kevinlog pushed a commit to kevinlog/kibana that referenced this pull request Jul 9, 2020
@efreeti @kevinlog
Fixing the consistency of util bar in endpoints and policies pages. (e…
7de4138 
…lastic#71133)
kevinlog added a commit that referenced this pull request Jul 9, 2020
@kevinlog @efreeti
Fixing the consistency of util bar in endpoints and policies pages. (#…
c72fff6 
…71133) (#71305)

Co-authored-by: Bohdan Tsymbala <slip777sg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees

@efreeti efreeti

Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@efreeti @elasticmachine @kevinlog @kibanamachine @paul-tavares