Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Fix and improve agent status #71009

Merged
merged 4 commits into from
Jul 9, 2020

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jul 7, 2020

Summary

Resolve:

API change

@michalpristas @blakerouse the checkin api will now accept a status?: "online" | "error" | "degraded" property in the request body. If the agent set the status to error or degraded it will stay like this until you checkin with a status of online

UI change

@hbharding @mostlyjason does this make sense?

Show a status of enrolling instead of error when the agent is enrolling and waiting for the first checkin
Screen Shot 2020-07-07 at 2 47 55 PM
Online when the agent is running
Screen Shot 2020-07-07 at 2 48 25 PM
Offline instead of error if the agent did not checkin recently
Screen Shot 2020-07-07 at 2 53 23 PM
Degraded or Error if the agent report an error
Screen Shot 2020-07-07 at 3 49 51 PM

Unenrolling when the agent is in the process of unenrolling -> inactive after
Screen Shot 2020-07-07 at 3 56 46 PM

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 7, 2020
@nchaulet nchaulet self-assigned this Jul 7, 2020
@nchaulet nchaulet changed the title Feature ingest agent status [Ingest Manager] Fix and improve agent status Jul 7, 2020
@mostlyjason
Copy link
Contributor

@nchaulet looks good! My only question is when an agent has unenrolled, when does it get removed from the Fleet page? It'd be nice to have a way to clear the page of Agents that are not relevant anymore.

@nchaulet
Copy link
Member Author

nchaulet commented Jul 7, 2020

When the agent succesfully unenroll it become inactive an it's not displayed in the list anymore unless you activate the filter show inactive

Screen Shot 2020-07-07 at 4 16 42 PM

@nchaulet nchaulet marked this pull request as ready for review July 8, 2020 13:34
@nchaulet nchaulet requested a review from a team July 8, 2020 13:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet
Copy link
Member Author

nchaulet commented Jul 8, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants