Add developer docs item to PULL_REQUEST_TEMPLATE.md #70872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrhodes
approved these changes
Jul 6, 2020
| @@ -7,7 +7,8 @@ Summarize your PR. If it involves visual changes include a screenshot or gif. | |||
| Delete any items that are not applicable to this PR. | |||
|
|
|||
| - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) | |||
| - [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials | |||
| - [ ] [User Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials | |||
| - [ ] Developer Documentation was added for any plugin APIs that are exposed to other plugins. | |||
There was a problem hiding this comment.
Documentation was added or updated for any new, updated, or removed APIs that are publicly exposed for use outside of this plugin. These docs should include, at a minimum, a list of available methods with associated descriptions and an example of how to access and use each available method in the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #67764 is merged, we could link to a section in that doc that explains what is expected.