Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics + Logs UI] Add test for logs and metrics telemetry #70858

Merged
merged 10 commits into from
Jul 13, 2020
Merged

[Metrics + Logs UI] Add test for logs and metrics telemetry #70858

merged 10 commits into from
Jul 13, 2020
+120 −1

Conversation

phillipb
Copy link
Contributor

@phillipb phillipb commented Jul 6, 2020 •
edited
Loading

Summary

Tests to visit pages in logs and metrics and verify that telemetry is being properly calculated.

Fixes: #67063

Checklist

Delete any items that are not applicable to this PR.

@phillipb phillipb added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services 7.9.0 labels Jul 6, 2020
@phillipb phillipb requested a review from a team as a code owner July 6, 2020 18:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@phillipb phillipb added the release_note:skip Skip the PR/issue when compiling release notes label Jul 6, 2020
@phillipb phillipb changed the title Add test for logs and metrics telemetry [Metrics + Logs UI] Add test for logs and metrics telemetry Jul 6, 2020
@spalger spalger added v7.9.0 and removed 7.9.0 labels Jul 6, 2020
@phillipb
Copy link
Contributor Author

phillipb commented Jul 7, 2020

@elasticmachine merge upstream

@phillipb
Copy link
Contributor Author

phillipb commented Jul 7, 2020

@elasticmachine merge upstream

Zacqary
Zacqary approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb merged commit 4bdd31e into elastic:master Jul 13, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 13, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
cd0522e 
* master: (28 commits)
  skip flaky suite (elastic#71361)
  [Ingest Manager] Add UI to enroll standalone agent (elastic#71288)
  Node options from cfg file for production (elastic#62468)
  [APM] Improvements to the ML Settings page (elastic#71309)
  add old .chromium to gitignore to prevent it from being accidentally committed
  [Ingest Manager] Simplify add/edit package config (integration) form (elastic#71187)
  Ensure Other bucket works on scripted fields. (elastic#71329)
  [APM] Anomaly detection setup link with alert if job doesn't exist (elastic#71229)
  [APM] Anomaly detection integration with transaction duration chart (elastic#71230)
  inclusive language (elastic#71438)
  [Ingest Manager] During fleet setup create an enrollment for every config (elastic#71308)
  Improvements to our developer guide (elastic#67764)
  [SIEM][Detections] Fixes index patterns order (elastic#71270)
  [Metrics + Logs UI] Add test for logs and metrics telemetry (elastic#70858)
  [Maps] Inclusive language (elastic#71427)
  [Logs UI] Unskip log highlight api integration test (elastic#71058)
  [Security_Solution][Resolver] Style adjustments per UX (elastic#71179)
  [Functional test] Increase the timeout to click new vis function (elastic#71226)
  [Discover] Migrate async import of embeddable factory to actual embeddable (elastic#70920)
  fix overflow (elastic#70723)
  ...
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70858 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 15, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70858 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70858 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70858 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70858 or prevent reminders by adding the backport:skip label.

@jasonrhodes jasonrhodes mentioned this pull request Jul 21, 2020
Closed
@phillipb phillipb mentioned this pull request Jul 21, 2020
Merged
phillipb added a commit to phillipb/kibana that referenced this pull request Jul 21, 2020
@phillipb @elasticmachine
[Metrics + Logs UI] Add test for logs and metrics telemetry (elastic#…
c07b693 
…70858)

* Add test for logs and metrics telemetry

* wait before you go

* Remove kubenetes

* Fix type check

* Add back kubernetes test

* Remove kubernetes

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
phillipb added a commit that referenced this pull request Jul 21, 2020
@phillipb @elasticmachine
[Metrics + Logs UI] Add test for logs and metrics telemetry (#70858) (#…
94bb21c 
…72657)

* Add test for logs and metrics telemetry

* wait before you go

* Remove kubenetes

* Fix type check

* Add back kubernetes test

* Remove kubernetes

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zacqary Zacqary Zacqary approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs UI] + [Metrics UI] Add tests for telemetry reporting
5 participants
@phillipb @elasticmachine @kibanamachine @Zacqary @spalger