[7.x] Fixed adding an extra space character on selecting alert variable in action text fields (#70028) #70761

YulNaumenko · 2020-07-05T21:32:05Z

Backports the following commits to 7.x:

Fixed adding an extra space character on selecting alert variable in action text fields (Fixed adding an extra space character on selecting alert variable in action text fields #70028)

…action text fields (elastic#70028) * Fixed adding an extra space character on selecting alert variable in action text fields. * Made components for variables to be able to insert the variable by the cursor position * cleanup * Added variables support for all components * update on handle selections for text * Fixed functional tests

kibanamachine · 2020-07-05T22:59:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: c76d4bd
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Execute kibana-intake

Test Failures

Kibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-optimizer/src/integration_tests.builds expected bundles, saves bundle counts to metadata

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 45 times on tracked branches: https://github.com/elastic/kibana/issues/70753

Stack Trace

Error: expected optimizer to produce two or three "running" states, states: [ { state:
     { phase: 'initializing',
       compilerStates: [],
       offlineBundles: [],
       onlineBundles: [],
       startTime: 1593988937114,
       durSec: 0 } },
  { event:
     { type: 'bundle not cached',
       reason: 'missing optimizer cache key',
       bundle:
        Bundle {
          type: 'plugin',
          id: 'bar',
          publicDirNames: [ 'public' ],
          contextDir:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
          sourceRoot:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
          outputDir:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
          cache:
           BundleCache {
             path:
              '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
             state: {} } } },
    state:
     { phase: 'initializing',
       compilerStates: [],
       offlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1593988937114,
       durSec: 0.1 } },
  { event:
     { type: 'bundle not cached',
       reason: 'missing optimizer cache key',
       bundle:
        Bundle {
          type: 'plugin',
          id: 'foo',
          publicDirNames: [ 'public' ],
          contextDir:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
          sourceRoot:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
          outputDir:
           '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
          cache:
           BundleCache {
             path:
              '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
             state: {} } } },
    state:
     { phase: 'initializing',
       compilerStates: [],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1593988937114,
       durSec: 0.1 } },
  { event: { type: 'optimizer initialized' },
    state:
     { phase: 'initialized',
       compilerStates: [],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1593988937114,
       durSec: 0.1 } },
  { event:
     { type: 'worker started',
       bundles:
        [ Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } } ] },
    state:
     { phase: 'initialized',
       compilerStates: [],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1593988937114,
       durSec: 0.8 } },
  { event: { bundleId: 'foo', type: 'running' },
    state:
     { phase: 'running',
       compilerStates: [ { bundleId: 'foo', type: 'running' } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1593988937114,
       durSec: 1.1 } },
  { event: { bundleId: 'bar', type: 'running' },
    state:
     { phase: 'running',
       compilerStates:
        [ { bundleId: 'foo', type: 'running' },
          { bundleId: 'bar', type: 'running' } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1593988937114,
       durSec: 1.1 } },
  { event:
     { bundleId: 'foo', type: 'compiler success', moduleCount: 6 },
    state:
     { phase: 'running',
       compilerStates:
        [ { bundleId: 'bar', type: 'running' },
          { bundleId: 'foo', type: 'compiler success', moduleCount: 6 } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1593988937114,
       durSec: 2.1 } },
  { event:
     { type: 'worker stdio',
       line:
        'Browserslist: caniuse-lite is outdated. Please run the following command: `yarn upgrade`',
       stream: 'stderr' },
    state:
     { phase: 'running',
       compilerStates:
        [ { bundleId: 'bar', type: 'running' },
          { bundleId: 'foo', type: 'compiler success', moduleCount: 6 } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1593988937114,
       durSec: 2.6 } },
  { event:
     { bundleId: 'bar', type: 'compiler success', moduleCount: 18 },
    state:
     { phase: 'success',
       compilerStates:
        [ { bundleId: 'foo', type: 'compiler success', moduleCount: 6 },
          { bundleId: 'bar', type: 'compiler success', moduleCount: 18 } ],
       offlineBundles: [],
       onlineBundles:
        [ Bundle {
            type: 'plugin',
            id: 'bar',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/bar/target/public/.kbn-optimizer-cache',
               state: {} } },
          Bundle {
            type: 'plugin',
            id: 'foo',
            publicDirNames: [ 'public' ],
            contextDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo',
            sourceRoot:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo',
            outputDir:
             '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public',
            cache:
             BundleCache {
               path:
                '/dev/shm/workspace/kibana/packages/kbn-optimizer/src/__fixtures__/__tmp__/mock_repo/plugins/foo/target/public/.kbn-optimizer-cache',
               state: {} } } ],
       startTime: 1593988937114,
       durSec: 2.8 } } ]
    at assert (/dev/shm/workspace/kibana/packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts:82:13)
    at Object.<anonymous>.it (/dev/shm/workspace/kibana/packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts:108:3)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
triggers_actions_ui	146	+3	143

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

YulNaumenko added the backport label Jul 5, 2020

YulNaumenko closed this Jul 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7.x] Fixed adding an extra space character on selecting alert variable in action text fields (#70028) #70761

[7.x] Fixed adding an extra space character on selecting alert variable in action text fields (#70028) #70761

YulNaumenko commented Jul 5, 2020

kibanamachine commented Jul 5, 2020

Standard Out

Stack Trace

[7.x] Fixed adding an extra space character on selecting alert variable in action text fields (#70028) #70761

[7.x] Fixed adding an extra space character on selecting alert variable in action text fields (#70028) #70761

Conversation

YulNaumenko commented Jul 5, 2020

kibanamachine commented Jul 5, 2020

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Build metrics

@kbn/optimizer bundle module count