Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logout from transform_poweruser user in after method of transform tests #70644

Merged
merged 3 commits into from
Jul 3, 2020

Conversation

LeeDr
Copy link
Contributor

@LeeDr LeeDr commented Jul 2, 2020

Summary

Fixes: #68847

The transform tests create roles and a transform_poweruser and run as that user. Most other tests are running as test_user and we have methods for managing the roles that test_user has. But when reporting test runs right after transform test it's still logged in as the transform_poweruser. This PR just adds a call to logout() in the after method of the transform tests.

@LeeDr LeeDr added test_xpack_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 2, 2020
@LeeDr LeeDr requested a review from a team as a code owner July 2, 2020 19:56
@LeeDr
Copy link
Contributor Author

LeeDr commented Jul 2, 2020

@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko
Copy link
Member

@elasticmachine merge upstream

@LeeDr
Copy link
Contributor Author

LeeDr commented Jul 3, 2020

tests all passed on the last run bug ci failed with;

21:56:59  Fetching upstream changes from git@github.com:elastic/kibana.git
21:56:59   > git --version # timeout=10
21:56:59  using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
21:57:00   > git fetch --tags --force --progress -- git@github.com:elastic/kibana.git +refs/heads/*:refs/remotes/origin/* # timeout=10
21:57:32  ERROR: Error cloning remote repo 'origin'
21:57:32  hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- git@github.com:elastic/kibana.git +refs/heads/*:refs/remotes/origin/*" returned status code 128:
21:57:32  stdout: 
21:57:32  stderr: ssh: connect to host github.com port 22: Connection timed out
21:57:32  fatal: Could not read from remote repository.
21:57:32  
21:57:32  Please make sure you have the correct access rights
21:57:32  and the repository exists.

@LeeDr
Copy link
Contributor Author

LeeDr commented Jul 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@LeeDr LeeDr merged commit c3cacba into elastic:master Jul 3, 2020
@LeeDr LeeDr deleted the transformAfterLogout branch July 3, 2020 18:14
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Jul 3, 2020
…ts (elastic#70644)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
LeeDr pushed a commit that referenced this pull request Jul 3, 2020
…rm tests (#70644) (#70738)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 6, 2020
* master:
  [APM-UI] e2e speed up build (elastic#70704)
  skip flaky suite (elastic#70764)
  skip flaky suite (elastic#70762)
  [Security Solution][Endpoint] Update to new manifest format (without compression) (elastic#70752)
  [functional tests] test url field formatter on dashboard and discover (elastic#70736)
  logout from transform_poweruser user in after method of transform tests (elastic#70644)
  [SECURITY] Bug fix for topN on draggables (elastic#70450)
  [Logs UI] Reorganise log rate anomaly table (elastic#69516)
  Update dependency @elastic/charts to v19.7.0 (elastic#69791)
  Add googlecloud metricbeat module to Kibana Home (elastic#70652)
  [Logs UI] Logs overview queries for the observability dashboard (elastic#70413)
  [Lens] Fitting functions (elastic#69820)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 6, 2020
* master:
  [APM-UI] e2e speed up build (elastic#70704)
  skip flaky suite (elastic#70764)
  skip flaky suite (elastic#70762)
  [Security Solution][Endpoint] Update to new manifest format (without compression) (elastic#70752)
  [functional tests] test url field formatter on dashboard and discover (elastic#70736)
  logout from transform_poweruser user in after method of transform tests (elastic#70644)
  [SECURITY] Bug fix for topN on draggables (elastic#70450)
  [Logs UI] Reorganise log rate anomaly table (elastic#69516)
  Update dependency @elastic/charts to v19.7.0 (elastic#69791)
  Add googlecloud metricbeat module to Kibana Home (elastic#70652)
  [Logs UI] Logs overview queries for the observability dashboard (elastic#70413)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 6, 2020
* actions/feature:
  fixed type errors
  [APM-UI] e2e speed up build (elastic#70704)
  skip flaky suite (elastic#70764)
  skip flaky suite (elastic#70762)
  [Security Solution][Endpoint] Update to new manifest format (without compression) (elastic#70752)
  [functional tests] test url field formatter on dashboard and discover (elastic#70736)
  logout from transform_poweruser user in after method of transform tests (elastic#70644)
  [SECURITY] Bug fix for topN on draggables (elastic#70450)
  [Logs UI] Reorganise log rate anomaly table (elastic#69516)
  Update dependency @elastic/charts to v19.7.0 (elastic#69791)
  Add googlecloud metricbeat module to Kibana Home (elastic#70652)
  [Logs UI] Logs overview queries for the observability dashboard (elastic#70413)
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Jul 7, 2020
…ts (elastic#70644)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
LeeDr pushed a commit that referenced this pull request Jul 7, 2020
…rm tests (#70644) (#70973)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@LeeDr LeeDr added the v7.8.1 label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants