-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualize] Add unit tests #70410
[Visualize] Add unit tests #70410
Conversation
# Conflicts: # src/plugins/visualize/public/application/legacy_app.js
# Conflicts: # packages/kbn-telemetry-tools/src/tools/__fixture__/parsed_nested_collector.ts # src/fixtures/telemetry_collectors/unmapped_collector.ts # src/plugins/data/public/query/filter_manager/filter_manager.mock.ts # src/plugins/discover/public/application/components/skip_bottom_button/skip_bottom_button.test.tsx # src/plugins/kibana_utils/common/default_feedback_message.ts # src/plugins/visualize/public/application/app.tsx # src/plugins/visualize/public/application/components/index.ts # src/plugins/visualize/public/application/components/visualize_editor.tsx # src/plugins/visualize/public/application/help_menu/help_menu_util.js # src/plugins/visualize/public/application/types.ts # src/plugins/visualize/public/application/utils/get_top_nav_config.tsx # src/plugins/visualize/public/application/utils/index.ts # src/plugins/visualize/public/application/utils/use/index.ts # src/plugins/visualize/public/application/utils/use/use_chrome_visibility.ts # src/plugins/visualize/public/application/visualize_app.ts # src/plugins/visualize/public/plugin.ts
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So happy with this PR :) Code is LGTM 🍪
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm - thanks for adding these!
# Conflicts: # src/plugins/data/public/query/mocks.ts
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests should allow creation of lens visualizationsStandard Out
Stack Trace
Build metrics
History
To update your PR or re-run it, just comment with: |
* Reactify visualize app * Fix typescript failures after merging master * Make sure refresh button works * Subscribe filter manager fetches * Use redirect to landing page * Update savedSearch type * Add check for TSVB is loaded * Add unit tests for useSavedVisInstance effect * Fix comments * Fix uiState persistence on vis load * Remove extra div around TableListView * Update DTS selectors * Add error handling for embeddable * Add unit tests for createVisualizeAppState * Add unit tests for useChromeVisibility * Add filter_manager.mock * Add unit tests for useVisualizeAppState * Use app state stub * Add unit tests for useLinkedSearchUpdates * Add unit tests for useEditorUpdates * Remove extra argument from useEditorUpdates effect * Update comments, fix typos * Remove extra div wrapper * Apply design suggestions * Revert accidental config changes * Add unit tests for useEditorUpdates * Use visualize services mock * Add unit tests for getVisualizationInstance * Fix eslint warnings Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/data/public/query/mocks.ts
Summary
This PR adds unit tests for custom hooks in
visualize
app and for few helpers.coverage for
src/plugins/visualize/public/application/utils/use/
folder:coverage for
src/plugins/visualize/public/application/utils
folder:Checklist
Delete any items that are not applicable to this PR.
For maintainers