Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Reenabling Cypress tests #70397

Merged
merged 4 commits into from
Jul 2, 2020
Merged

[SIEM] Reenabling Cypress tests #70397

merged 4 commits into from
Jul 2, 2020

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Jul 1, 2020 •
edited
Loading

Reenabling Cypress tests.

Skips:

  • Overview Page
  • Search Bar
  • Sets and reads the url state for timeline by id'

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 1, 2020
@MadameSheema MadameSheema self-assigned this Jul 1, 2020
@MadameSheema MadameSheema marked this pull request as ready for review July 1, 2020 17:33
@MadameSheema MadameSheema requested review from a team as code owners July 1, 2020 17:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

FrankHassanabad
FrankHassanabad approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MadameSheema MadameSheema merged commit 257c115 into elastic:master Jul 2, 2020
@MadameSheema MadameSheema deleted the reenabling-cypress branch July 2, 2020 05:49
@MadameSheema MadameSheema mentioned this pull request Jul 2, 2020
Merged
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Jul 2, 2020
@MadameSheema
[SIEM] Reenabling Cypress tests (elastic#70397)
789af77 
* reenabling cypress

* skips Overview tests

* skips search bar test

* skips URL test
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 2, 2020
@gmmorris
Merge branch 'master' into alerting/built-in-alerts-feature
0e001e6 
* master: (46 commits)
  [Visualize] Add missing advanced settings and custom label for pipeline aggs (elastic#69688)
  Use dynamic: false for config saved object mappings (elastic#70436)
  [Ingest Pipelines] Error messages (elastic#70167)
  [APM] Show transaction rate per minute on Observability Overview page (elastic#70336)
  Filter out error when calculating a label (elastic#69934)
  [Visualizations] Each visType returns its supported triggers (elastic#70177)
  [Telemetry] Report data shippers (elastic#64935)
  Reduce SavedObjects mappings for Application Usage (elastic#70475)
  [Lens] fix dimension label performance issues (elastic#69978)
  Skip failing endgame tests (elastic#70548)
  [SIEM] Reenabling Cypress tests (elastic#70397)
  [SIEM][Security Solution][Endpoint] Endpoint Artifact Manifest Management + Artifact Download and Distribution (elastic#67707)
  [Security] Adds field mapping support to rule creation (elastic#70288)
  SECURITY-ENDPOINT: add fields for events to metadata document (elastic#70491)
  Fixed assertion in hybrid index pattern test to iterate through indices (elastic#70130)
  [SIEM][Exceptions] - Exception builder component (elastic#67013)
  [Ingest Manager] Rename data sources to package configs (elastic#70259)
  skip suites blocking es snapshot promomotion (elastic#70532)
  [Metrics UI] Fix asynchronicity and error handling in Snapshot API (elastic#70503)
  fix export response (elastic#70473)
  ...
@mistic mistic mentioned this pull request Jul 2, 2020
Merged
MadameSheema added a commit that referenced this pull request Jul 3, 2020
@MadameSheema @elasticmachine
[7.x] [SIEM] Reenabling Cypress tests (#70397) (#70551)
4548d3d 
* [SIEM] Reenabling Cypress tests (#70397)

* reenabling cypress

* skips Overview tests

* skips search bar test

* skips URL test

* fixes merge issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @kibanamachine @FrankHassanabad @MindyRS