Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Styles] Update the paste, review, and install filebeat screen styles #7033

Merged
merged 8 commits into from
Apr 29, 2016

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Apr 22, 2016

Paste Screen

  • Fixed header and descriptive text
  • Fixed textarea color and borders
  • Pulled some of the styles from the pipeline screen code into a reusable _add_data_wizard.less file for styles that apply across all of the wizards.

screen shot 2016-04-21 at 7 40 15 pm

Review Screen

  • Fixed header and descriptive text
  • Matched styling of other Add Data form controls
  • Updated style of paginated table
  • Pulled index pattern descriptive text out tool tip and placed it below the inupt label
  • Placed more styles in the generic Add data wizard stylesheet

screen shot 2016-04-22 at 5 30 01 pm

Install Filebeat Screen

  • Updated header text
  • Added bold taglines
  • Added info-circle icons to doc links
  • Adjusted index checker style

screen shot 2016-04-22 at 7 02 31 pm

@Bargs Bargs force-pushed the ingest/installFilebeatStyles branch from 833e2d6 to 302d5fe Compare April 29, 2016 15:21
@Bargs Bargs changed the title [Styles] Update the install filebeat screen styles [Styles] Update the paste, review, and install filebeat screen styles Apr 29, 2016
@Bargs
Copy link
Contributor Author

Bargs commented Apr 29, 2016

jenkins, test it

.paste-samples {
textarea {
width: 100%;
height: 250px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make this 450px like the pipeline-setup step? @alt74

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alt74 for reference, here's how 250px and 450px look, respectively. To me 450px looks a bit odd here since it starts out as a giant empty box.

screen shot 2016-04-29 at 2 50 38 pm

screen shot 2016-04-29 at 2 51 19 pm

@BigFunger
Copy link
Contributor

src/plugins/kibana/public/settings/sections/indices/filebeat/styles/_filebeat_wizard.less
The 'common styles?' section needs to be addressed, although I don't think it's a blocker.

Added #7095 to address this

@BigFunger BigFunger assigned Bargs and unassigned BigFunger Apr 29, 2016
@Bargs Bargs assigned BigFunger and unassigned Bargs Apr 29, 2016
@BigFunger
Copy link
Contributor

LGTM

@BigFunger BigFunger assigned Bargs and unassigned BigFunger Apr 29, 2016
@alt74
Copy link

alt74 commented Apr 29, 2016

@Bargs @BigFunger around 250 px height for the sample logs box works for me (1. Paste screen). A really large box creates the impression I have to paste a lot of example logs.

@Bargs Bargs merged commit 3f18f8e into elastic:feature/ingest Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants