Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY] Updates mappings and re-enables tests #69872

Closed
wants to merge 2 commits into from
Closed

[SECURITY] Updates mappings and re-enables tests #69872

wants to merge 2 commits into from

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Jun 25, 2020 •
edited
Loading

The provided mappings were resulting in > 1k mapping fields after a migration. This updates them so there aren't any dangling fields so the tests can be re-enabled.

We probably want to wait until #69871 is merged and update the mappings here again.

Closes #69848
Blocked on #69871

@tylersmalley tylersmalley added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic
Copy link
Contributor

@elasticmachine merge upstream

Tyler Smalley added 2 commits July 1, 2020 09:01
[SECURITY] Re-enables tests
875cb34 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
TEMP: comment to trigger SIEM Cypress tests
63ec50c 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley force-pushed the re-enable-siem-cypress branch from 1bb0e92 to 63ec50c Compare July 1, 2020 16:02
@tylersmalley tylersmalley requested review from a team as code owners July 1, 2020 16:02
@tylersmalley
Copy link
Contributor Author

Since #69871 was merged - I am re-enabling the tests here to see if they can be restored.

@tylersmalley
Copy link
Contributor Author

@stephmilovic, looks like we no longer have the field count error - but appears there are now some actual failing tests. Could you or someone from your team take over from here?

@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Test Failures

Kibana Pipeline / kibana-xpack-agent / Host stats render with correct values.Overview Page Host stats render with correct values

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

AssertionError: Timed out retrying: Expected to find element: `[data-test-subj="overview-hosts-stats"]`, but never found it.
    at ensureExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:137673:32)
    at Object.ensureElExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:137691:12)
    at ensureExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:127867:23)
    at onFailFn (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:127905:9)
    at tryCatcher (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:9065:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7000:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7057:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7102:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7178:18)
    at _drainQueueStep (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3772:12)
    at _drainQueue (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3765:9)
    at Async.../../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3781:5)
    at Async.drainQueues (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3651:14)
Kibana Pipeline / kibana-xpack-agent / Host stats render with correct values.Overview Page Host stats render with correct values

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://dryrun

Stack Trace

AssertionError: Timed out retrying: Expected to find element: `[data-test-subj="overview-hosts-stats"]`, but never found it.
    at ensureExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:137673:32)
    at Object.ensureElExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:137691:12)
    at ensureExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:127867:23)
    at onFailFn (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:127905:9)
    at tryCatcher (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:9065:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7000:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7057:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7102:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7178:18)
    at _drainQueueStep (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3772:12)
    at _drainQueue (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3765:9)
    at Async.../../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3781:5)
    at Async.drainQueues (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3651:14)
Kibana Pipeline / kibana-xpack-agent / Network stats render with correct values.Overview Page Network stats render with correct values

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

AssertionError: Timed out retrying: Expected to find element: `[data-test-subj="overview-network-stats"]`, but never found it.
    at ensureExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:137673:32)
    at Object.ensureElExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:137691:12)
    at ensureExistence (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:127867:23)
    at onFailFn (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:127905:9)
    at tryCatcher (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:9065:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7000:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7057:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7102:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7178:18)
    at _drainQueueStep (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3772:12)
    at _drainQueue (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3765:9)
    at Async.../../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3781:5)
    at Async.drainQueues (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:3651:14)

and 4 more failures, only showing the first 3.

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor Author

@elastic/siem & @stephmilovic, want to raise this again to see if someone on your team can take this over. There are failures not related to the field count which would need addressed from your team.

@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@tylersmalley @elasticmachine @stephmilovic @kibanamachine @MindyRS