Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Stabilize filter popover #69519

Merged
merged 3 commits into from
Jun 24, 2020
Merged

[Lens] Stabilize filter popover #69519

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58102e4
stabilize filter popovwer
flash1293 Jun 18, 2020
c06eb70
Merge remote-tracking branch 'upstream/master' into fix/lens-function…
flash1293 Jun 23, 2020
00e5d9b
remove text exclusion
flash1293 Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion x-pack/test/functional/apps/lens/smokescreen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const dashboardAddPanel = getService('dashboardAddPanel');
const elasticChart = getService('elasticChart');
const browser = getService('browser');
const retry = getService('retry');
const testSubjects = getService('testSubjects');
const filterBar = getService('filterBar');
const listingTable = getService('listingTable');
Expand Down Expand Up @@ -93,7 +94,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dashboardAddPanel.closeAddPanel();
await PageObjects.lens.goToTimeRange();
await clickOnBarHistogram();
await testSubjects.click('applyFiltersPopoverButton');

await retry.try(async () => {
await testSubjects.click('applyFiltersPopoverButton');
await testSubjects.missingOrFail('applyFiltersPopoverButton');
});

await assertExpectedChart();
await assertExpectedTimerange();
Expand Down