Consolidate capabilities check for Stack Management #69437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
force-pushed
the
management/consolidate-capabilities-check
branch
from
212bc6b
to
5f262de
Compare
legrego
commented
Jun 24, 2020
| @@ -24,6 +24,6 @@ export const capabilitiesProvider = () => ({ | |||
| visualize: true, | |||
| console: true, | |||
| advanced_settings: true, | |||
| index_patterns: true, | |||
| indexPatterns: true, | |||
There was a problem hiding this comment.
note: The NP migration for index pattern management changed the capability from index_patterns to indexPatterns, so this PR updates all references as appropriate.
legrego
added
Feature:Kibana Management
|
Pinging @elastic/kibana-security (Team:Security) |
…nsolidate-capabilities-check
pgayvallet
approved these changes
Jun 25, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Jun 29, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security.ts
legrego
added a commit
that referenced
this pull request
Jun 29, 2020
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, each management item secured by Feature Controls is responsible for disabling itself if its corresponding management UI Capability is disabled.
This PR removes the per-app logic in favor of a centralized approach, to reduce the chance of incorrect or missing checks.
Required by #67791
Also resolves #57377 (Flaky test runner for verification: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/546/)