Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Embed dashboard by value example & some embeddable clean up (#67783) #69163

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jun 15, 2020

Backports the following commits to 7.x:

…67783)

Added example for using dashboard container by value
1.1 Refactored embeddable explorer e2e test to use new example, removed not needed kbn_tp_embeddable_explorer plugin.
For embeddable explorer examples went away from using getFactoryById() to improve type checks
There is new component a replacement for EmbeddableFactoryRenderer with slightly more flexible api: EmbeddableRenderer.
3.1 We can improve it going forward to support more use case

# Conflicts:
#	renovate.json5
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
dashboard 334 +1 333
visualize 418 +1 417
apm 1612 +1 1611
dashboardMode 334 +1 333
infra 1612 +1 1611
ml 674 +1 673
transform 741 +1 740
uptime 1411 +1 1410
total - +8 -

page load asset size

beta
id value diff baseline
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.@elastic.js 4.0MB +1.0B 4.0MB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 4.5MB +20.2KB 4.5MB
/bundles/plugin/canvas/canvas.plugin.js 3.4MB +502.0B 3.4MB
/bundles/plugin/dashboard/dashboard.plugin.js 1.1MB +2.2KB 1.1MB
/bundles/plugin/dashboardEnhanced/dashboardEnhanced.plugin.js 754.2KB +109.0B 754.1KB
/bundles/plugin/dashboardMode/dashboardMode.plugin.js 1.1MB +2.2KB 1.1MB
/bundles/plugin/discover/discover.plugin.js 762.6KB +103.0B 762.5KB
/bundles/plugin/drilldowns/drilldowns.plugin.js 726.6KB +109.0B 726.5KB
/bundles/plugin/embeddable/embeddable.plugin.js 615.1KB +507.0B 614.6KB
/bundles/plugin/embeddableEnhanced/embeddableEnhanced.plugin.js 714.3KB +109.0B 714.2KB
/bundles/plugin/lens/lens.plugin.js 1.9MB +103.0B 1.9MB
/bundles/plugin/ml/ml.plugin.js 2.0MB +579.0B 2.0MB
/bundles/plugin/reporting/reporting.plugin.js 914.9KB +103.0B 914.8KB
/bundles/plugin/uiActionsEnhanced/uiActionsEnhanced.plugin.js 693.0KB +109.0B 692.9KB
/bundles/plugin/visualizations/visualizations.plugin.js 985.2KB +103.0B 985.1KB
/ui/fonts/inter_ui/Inter-UI-SemiBold.woff2 - -92.5KB 92.5KB
total - -65.5KB -

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 32331f2 into elastic:7.x Jun 16, 2020
@Dosant Dosant deleted the backport/7.x/pr-67783 branch June 16, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants