Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty index patterns page re-design #68819

Merged
merged 108 commits into from
Aug 12, 2020
Merged
Show file tree
Hide file tree
Changes from 90 commits
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
057412f
Remove old help flyout
Jun 8, 2020
83506f2
Update the No ES Data screen
Jun 9, 2020
7d58230
Added `EmptyIndexPatternPrompt` at `/empty`
Jun 9, 2020
ce7d96d
Added docLinks
Jun 9, 2020
f728594
Added styles to the new empty prompts
Jun 9, 2020
57d433a
Fixed up the wizard steps
Jun 9, 2020
143b0c0
Last bits of cleanup in a few views
Jun 10, 2020
67c73c8
Fix illustration in dark mode and (most) snaps
Jun 10, 2020
46aad26
Update API docs
Jun 10, 2020
95963d0
Merge branch 'master' into index_patterns/empty_screen
mattkime Jun 12, 2020
4b336df
use new endpoint
mattkime Jun 29, 2020
ae6b4ff
Merge branch 'master' into index_pattern_mgmt_resolve_api
mattkime Jun 30, 2020
fd159e3
appears to work, needs design tweaks
mattkime Jul 1, 2020
8225b45
Merge branch 'master' into index_pattern_mgmt_resolve_api
mattkime Jul 1, 2020
4e47b40
i18n fix
mattkime Jul 1, 2020
28aa1c9
Merge branch 'master' into index_pattern_mgmt_resolve_api
mattkime Jul 1, 2020
5833e7c
show hidden indices
mattkime Jul 1, 2020
92d58b7
Merge branch 'master' into index_pattern_mgmt_resolve_api
mattkime Jul 1, 2020
aa2aab9
Merge branch 'master' into index_patterns/empty_screen
mattkime Jul 2, 2020
289fc43
rendeing improvements
mattkime Jul 2, 2020
7e0698f
rendering improvements
mattkime Jul 2, 2020
1dd9636
rendering improvements
mattkime Jul 2, 2020
6a4eb08
typescript and test fixes
mattkime Jul 2, 2020
ce64bc3
Merge branch 'master' into index_pattern_mgmt_resolve_api
elasticmachine Jul 2, 2020
86859a7
i18n fix
mattkime Jul 2, 2020
c05f604
jest test fixes
mattkime Jul 2, 2020
1264260
Merge branch 'master' into index_pattern_mgmt_resolve_api
mattkime Jul 2, 2020
f4e1b36
fix and add tests for get_indices
mattkime Jul 2, 2020
43c2925
Merge branch 'index_pattern_mgmt_resolve_api' of github.com:mattkime/…
mattkime Jul 2, 2020
299091c
test field preselect and update snapshots
mattkime Jul 2, 2020
ddbe5a4
remove comments
mattkime Jul 3, 2020
ac09487
Merge branch 'master' into index_patterns/empty_screen
mattkime Jul 3, 2020
6adea1a
ui rendering updates
mattkime Jul 3, 2020
7dda4a0
simplify timestamp preset code
mattkime Jul 3, 2020
4fc3527
add functional test, update text
mattkime Jul 3, 2020
e40db39
fix functional test
mattkime Jul 3, 2020
fff348a
Merge branch 'master' into index_pattern_mgmt_resolve_api
mattkime Jul 3, 2020
7f8802e
fix functional tests
mattkime Jul 3, 2020
46b0a9d
Merge branch 'master' into index_patterns/empty_screen
mattkime Jul 3, 2020
cb28e99
source instead of index
mattkime Jul 4, 2020
1a4db4b
fix routing and state issues
mattkime Jul 5, 2020
ee83cad
Merge branch 'index_pattern_mgmt_resolve_api' into index_patterns/emp…
mattkime Jul 5, 2020
1ba8ea9
left over from merge
mattkime Jul 5, 2020
9f1b7bf
load data sources
mattkime Jul 5, 2020
557a474
Merge branch 'master' into index_patterns/empty_screen
elasticmachine Jul 5, 2020
9fd60ab
Merge branch 'master' into index_patterns/empty_screen
mattkime Jul 5, 2020
829f02e
Merge branch 'index_patterns/empty_screen' of github.com:cchaos/kiban…
mattkime Jul 5, 2020
6a38429
fix functional test
mattkime Jul 6, 2020
8d503c7
update snapshot
mattkime Jul 6, 2020
f5fd0c4
Merge branch 'master' into index_patterns/empty_screen
mattkime Jul 9, 2020
c7c74c5
from merge
mattkime Jul 9, 2020
f7c83c0
Merge branch 'master' into index_patterns/empty_screen
mattkime Jul 14, 2020
20b9685
add comment to kibana.json
mattkime Jul 14, 2020
6556e3a
Merge branch 'master' into index_patterns/empty_screen
mattkime Jul 16, 2020
e37572c
fix security functional test
mattkime Jul 17, 2020
9e40caf
remove unneeded comments, i18n text content
mattkime Jul 17, 2020
6332e41
add api to know if ml is available
mattkime Jul 17, 2020
71ccf70
Merge branch 'master' into index_patterns/empty_screen
mattkime Jul 18, 2020
9ce0540
fix security tests
mattkime Jul 18, 2020
e39c39f
update snapshot
mattkime Jul 18, 2020
094de5c
typescript fixes
mattkime Jul 18, 2020
f728360
try adding timeout
mattkime Jul 18, 2020
616325e
Merge branch 'master' into index_patterns/empty_screen
mattkime Jul 20, 2020
4de2cdd
fix tests
mattkime Jul 20, 2020
847e0e8
functional test - create logstash-a index
mattkime Jul 20, 2020
2c42d74
Design quick updates
Jul 20, 2020
ab9fca7
update snapshots
mattkime Jul 20, 2020
bdb1ee2
ingest manager is basic license too
mattkime Jul 21, 2020
1245471
fix jest tests
mattkime Jul 21, 2020
69044c8
Revert "fix jest tests"
mattkime Jul 21, 2020
336c746
Revert "ingest manager is basic license too"
mattkime Jul 21, 2020
615bcd9
Merge branch 'master' into index_patterns/empty_screen
elasticmachine Jul 22, 2020
4cd406b
Merge branch 'master' into index_patterns/empty_screen
elasticmachine Jul 23, 2020
6ff8d3c
Merge branch 'master' into index_patterns/empty_screen
mattkime Aug 1, 2020
4a47a00
Merge branch 'master' into index_patterns/empty_screen
mattkime Aug 3, 2020
d5049a2
functional test improvements
mattkime Aug 3, 2020
fddd47d
functional test improvements
mattkime Aug 3, 2020
631daed
functional test fix
mattkime Aug 3, 2020
027b2c4
localization fix
mattkime Aug 3, 2020
8431e16
functional test fixes
mattkime Aug 3, 2020
04a6f44
functional test fix
mattkime Aug 3, 2020
f238527
functional test fix
mattkime Aug 3, 2020
dcfc379
Merge branch 'master' into index_patterns/empty_screen
mattkime Aug 3, 2020
97bf9c6
kibana settings functional test tweak
mattkime Aug 4, 2020
c91d299
Merge branch 'master' into index_patterns/empty_screen
mattkime Aug 4, 2020
57def44
fix index patten creation for test
mattkime Aug 4, 2020
699c8ee
fix kibana setting functional test
mattkime Aug 4, 2020
140e48c
fix kibana setting functional test
mattkime Aug 4, 2020
8403897
fix kibana setting functional test
mattkime Aug 4, 2020
35f674c
fix kibana setting functional test
mattkime Aug 4, 2020
59fb3a4
fix kibana setting functional test
mattkime Aug 4, 2020
c4cf0fc
fix kibana setting functional test
mattkime Aug 4, 2020
2a643db
fix kibana setting functional test
mattkime Aug 4, 2020
f46afba
Update _index_patterns_empty.ts
mattkime Aug 4, 2020
6a63f53
Update _index_patterns_empty.ts
mattkime Aug 4, 2020
882a30f
Update _kibana_settings.js
mattkime Aug 4, 2020
ee565e6
Merge branch 'master' into index_patterns/empty_screen
mattkime Aug 5, 2020
efeb099
hide card when user doesn't have privs
mattkime Aug 6, 2020
94f5e62
Merge commit 'refs/pull/68819/head' of github.com:elastic/kibana into…
mattkime Aug 6, 2020
3ecbc25
Merge branch 'master' into index_patterns/empty_screen
mattkime Aug 6, 2020
4b75dbb
add required bundle
mattkime Aug 6, 2020
37bcd63
fix import path
mattkime Aug 7, 2020
728602c
Merge branch 'master' into index_patterns/empty_screen
elasticmachine Aug 10, 2020
a196e29
Update test/functional/page_objects/settings_page.ts
mattkime Aug 12, 2020
ce0b152
Merge branch 'master' into index_patterns/empty_screen
mattkime Aug 12, 2020
029e2ad
minor fixes
mattkime Aug 12, 2020
62b5f42
illsutation to tsx and update snapshot
mattkime Aug 12, 2020
1c39a74
fix jest test
mattkime Aug 12, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .sass-lint.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
files:
include:
- 'src/legacy/core_plugins/metrics/**/*.s+(a|c)ss'
- 'src/plugins/index_pattern_management/**/*.s+(a|c)ss'
- 'src/plugins/timelion/**/*.s+(a|c)ss'
- 'src/plugins/vis_type_vislib/**/*.s+(a|c)ss'
- 'src/plugins/vis_type_vega/**/*.s+(a|c)ss'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ readonly links: {
readonly loadingData: string;
readonly introduction: string;
};
readonly addData: string;
readonly kibana: string;
readonly siem: {
readonly guide: string;
Expand Down
2 changes: 1 addition & 1 deletion docs/setup/connect-to-elasticsearch.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Using a wildcard is the more popular approach.
comparisons.
+
Kibana reads the index mapping and lists all fields that contain a timestamp. If your
index doesn't have time-based data, choose *I don't want to use the Time Filter*.
index doesn't have time-based data, choose *I don't want to use the time filter*.
+
You must select a time field to use global time filters on your dashboards.

Expand Down
2 changes: 2 additions & 0 deletions src/core/public/doc_links/doc_links_service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export class DocLinksService {
loadingData: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/tutorial-load-dataset.html`,
introduction: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/index-patterns.html`,
},
addData: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/connect-to-elasticsearch.html`,
kibana: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/index.html`,
siem: {
guide: `${ELASTIC_WEBSITE_URL}guide/en/security/${DOC_LINK_VERSION}/index.html`,
Expand Down Expand Up @@ -209,6 +210,7 @@ export interface DocLinksStart {
readonly loadingData: string;
readonly introduction: string;
};
readonly addData: string;
readonly kibana: string;
readonly siem: {
readonly guide: string;
Expand Down
1 change: 1 addition & 0 deletions src/core/public/public.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,7 @@ export interface DocLinksStart {
readonly loadingData: string;
readonly introduction: string;
};
readonly addData: string;
readonly kibana: string;
readonly siem: {
readonly guide: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const onRedirectNoIndexPattern = (

const bannerMessage = i18n.translate('data.indexPatterns.ensureDefaultIndexPattern.bannerLabel', {
defaultMessage:
"In order to visualize and explore data in Kibana, you'll need to create an index pattern to retrieve data from Elasticsearch.",
'To visualize and explore data in Kibana, you must create an index pattern to retrieve data from Elasticsearch.',
});

// Avoid being hostile to new users who don't have an index pattern setup yet
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/index_pattern_management/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"version": "kibana",
"server": true,
"ui": true,
"requiredPlugins": ["management", "data", "kibanaLegacy"],
"requiredPlugins": ["management", "data", "kibanaLegacy","home"],
mattkime marked this conversation as resolved.
Show resolved Hide resolved
"requiredBundles": ["kibanaReact", "kibanaUtils"]
}
11 changes: 11 additions & 0 deletions src/plugins/index_pattern_management/public/_templates.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
%inp-empty-state-footer {
background: $euiColorLightestShade;
margin: 0 (-$euiSizeL) (-$euiSizeL);
padding: $euiSizeL;
border-radius: 0 0 $euiBorderRadius $euiBorderRadius;

// sass-lint:disable-block mixins-before-declarations
@include euiBreakpoint('xs', 's') {
text-align: center;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
$inpEmptyStateMaxWidth: $euiSizeXXL * 19;

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

Loading