[Lens] Fix selection of chart in functional test #68677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
force-pushed
the
lens/flaky-functional
branch
from
d9ca67e
to
1b0946d
Compare
|
@elasticmachine merge upstream |
… into lens/fix-flaky-test
wylieconlon
added
Feature:Lens
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
added
release_note:skip
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mbondyra
approved these changes
Jun 11, 2020
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Jun 11, 2020
* [Lens] Fix flaky test by closing options after use * [Lens] Fix selection of chart in functional test * Test delay * Filter listings to exact Lens title due to dirty test env Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
wylieconlon
pushed a commit
that referenced
this pull request
Jun 11, 2020
* [Lens] Fix flaky test by closing options after use * [Lens] Fix selection of chart in functional test * Test delay * Filter listings to exact Lens title due to dirty test env Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67838, which appears to have been caused by saved visualizations that are not being cleaned up in the functional test environment in cloud. By filtering the list of charts to the specific one that we care about, we can ignore the rest of the environment as part of the test.
I verified this test fixes it by running it in the cloud flaky test runner. Before, we would get a failure to find the "lnsXYvis" visualization in this list, because of the additional saved objects:
Checklist