Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix selection of chart in functional test #68677

Merged
merged 7 commits into from
Jun 11, 2020

Conversation

wylieconlon
Copy link
Contributor

@wylieconlon wylieconlon commented Jun 9, 2020

Fixes #67838, which appears to have been caused by saved visualizations that are not being cleaned up in the functional test environment in cloud. By filtering the list of charts to the specific one that we care about, we can ignore the rest of the environment as part of the test.

I verified this test fixes it by running it in the cloud flaky test runner. Before, we would get a failure to find the "lnsXYvis" visualization in this list, because of the additional saved objects:

lens app lens smokescreen tests click on the bar in XYChart adds proper filters_timerange in dashboard

Checklist

@wylieconlon
Copy link
Contributor Author

@elasticmachine merge upstream

@wylieconlon wylieconlon added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 11, 2020
@wylieconlon wylieconlon marked this pull request as ready for review June 11, 2020 00:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jun 11, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving it! 😻

@wylieconlon wylieconlon merged commit 02b2cdc into elastic:master Jun 11, 2020
@wylieconlon wylieconlon deleted the lens/flaky-functional branch June 11, 2020 13:16
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Jun 11, 2020
* [Lens] Fix flaky test by closing options after use

* [Lens] Fix selection of chart in functional test

* Test delay

* Filter listings to exact Lens title due to dirty test env

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
wylieconlon pushed a commit that referenced this pull request Jun 11, 2020
* [Lens] Fix flaky test by closing options after use

* [Lens] Fix selection of chart in functional test

* Test delay

* Filter listings to exact Lens title due to dirty test env

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v8.0.0
Projects
None yet
4 participants