Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include ci-stats metrics in pr comment #68563

Merged
merged 7 commits into from
Jun 12, 2020
Merged

include ci-stats metrics in pr comment #68563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ded15c0
include ci-stats metrics in pr comment
spalger Jun 8, 2020
fb44855
add a module/change asset size for testing
spalger Jun 10, 2020
4d0c782
Merge branch 'master' of github.com:elastic/kibana into implement/ci-…
spalger Jun 10, 2020
d0cd76a
remove test-related changes
spalger Jun 10, 2020
47254a8
Merge branch 'master' into implement/ci-stats/metrics-report
elasticmachine Jun 10, 2020
56ade55
Merge branch 'master' into implement/ci-stats/metrics-report
elasticmachine Jun 10, 2020
43f809d
Merge branch 'master' into implement/ci-stats/metrics-report
elasticmachine Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ library 'kibana-pipeline-library'
kibanaLibrary.load()

kibanaPipeline(timeoutMinutes: 155, checkPrChanges: true) {
ciStats.trackBuild {
githubPr.withDefaultPrComments {
githubPr.withDefaultPrComments {
ciStats.trackBuild {
catchError {
retryable.enable()
parallel([
Expand Down Expand Up @@ -53,10 +53,10 @@ kibanaPipeline(timeoutMinutes: 155, checkPrChanges: true) {
])
}
}
}

if (params.NOTIFY_ON_FAILURE) {
slackNotifications.onFailure()
kibanaPipeline.sendMail()
}
if (params.NOTIFY_ON_FAILURE) {
slackNotifications.onFailure()
kibanaPipeline.sendMail()
}
}
1 change: 1 addition & 0 deletions vars/githubPr.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ def getNextCommentMessage(previousCommentInfo = [:]) {
}

messages << getTestFailuresMessage()
messages << ciStats.getMetricsReport()
Copy link
Contributor

@mshustov mshustov Jun 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for self-education: how is it mapped to a function or remote call? ok, found kibana-pipeline-library


if (info.builds && info.builds.size() > 0) {
messages << getHistoryText(info.builds)
Expand Down