Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Fix draft timeline can be attached to a case #67844

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Jun 1, 2020

Summary

Right now you can attach a draft timeline to a case. This could be confusing for the user since the timeline draft is going to be overridden if a title is not entered when creating a new one.
For the user, this could end up having attached into a case a timeline that is not expecting.

The solution is to disable the "Attach" button when the Timeline has a draft status.

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@patrykkopycinski patrykkopycinski requested review from a team as code owners June 1, 2020 11:07
@patrykkopycinski patrykkopycinski self-assigned this Jun 1, 2020
@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience Team:SIEM v7.8.0 labels Jun 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label Jun 1, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit e2ddf8b into elastic:master Jun 2, 2020
@patrykkopycinski patrykkopycinski deleted the fix/attach-draft-timeline-case branch June 2, 2020 09:28
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jun 2, 2020
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jun 2, 2020
# Conflicts:
#	x-pack/plugins/siem/public/timelines/components/flyout/header/index.tsx
#	x-pack/plugins/siem/public/timelines/components/timeline/properties/helpers.tsx
#	x-pack/plugins/siem/public/timelines/components/timeline/properties/index.test.tsx
#	x-pack/plugins/siem/public/timelines/components/timeline/properties/index.tsx
#	x-pack/plugins/siem/public/timelines/components/timeline/properties/properties_right.tsx
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants