Bump TypeScript to v3.9

package.json

@@ -87,7 +87,7 @@
     "**/@types/angular": "^1.6.56",
     "**/@types/hoist-non-react-statics": "^3.3.1",
     "**/@types/chai": "^4.2.11",
-    "**/typescript": "3.7.2",
+    "**/typescript": "3.9.3",
     "**/graphql-toolkit/lodash": "^4.17.13",
     "**/hoist-non-react-statics": "^3.3.2",
     "**/isomorphic-git/**/base64-js": "^1.2.1",
@@ -273,7 +273,7 @@
     "tinygradient": "0.4.3",
     "tinymath": "1.2.1",
     "topojson-client": "3.0.0",
-    "tslib": "^1.9.3",
+    "tslib": "^2.0.0",
     "type-detect": "^4.0.8",
     "ui-select": "0.19.8",
     "url-loader": "2.2.0",
@@ -395,8 +395,8 @@
     "@types/uuid": "^3.4.4",
     "@types/vinyl-fs": "^2.4.11",
     "@types/zen-observable": "^0.8.0",
-    "@typescript-eslint/eslint-plugin": "^2.33.0",
-    "@typescript-eslint/parser": "^2.33.0",
+    "@typescript-eslint/eslint-plugin": "^2.34.0",
+    "@typescript-eslint/parser": "^2.34.0",
     "angular-mocks": "^1.7.9",
     "archiver": "^3.1.1",
     "axe-core": "^3.4.1",
@@ -496,7 +496,7 @@
     "supertest-as-promised": "^4.0.2",
     "tape": "^4.13.0",
     "tree-kill": "^1.2.2",
-    "typescript": "3.7.2",
+    "typescript": "3.9.3",
     "typings-tester": "^0.3.2",
     "vinyl-fs": "^3.0.3",
     "xml2js": "^0.4.22",

packages/elastic-datemath/package.json

@@ -17,7 +17,7 @@
     "moment": "^2.24.0"
   },
   "dependencies": {
-    "tslib": "^1.9.3"
+    "tslib": "^2.0.0"
   },
   "peerDependencies": {
     "moment": "^2.24.0"

packages/eslint-config-kibana/package.json

@@ -15,8 +15,8 @@
   },
   "homepage": "https://github.com/elastic/eslint-config-kibana#readme",
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "^2.33.0",
-    "@typescript-eslint/parser": "^2.33.0",
+    "@typescript-eslint/eslint-plugin": "^2.34.0",
+    "@typescript-eslint/parser": "^2.34.0",
     "babel-eslint": "^10.0.3",
     "eslint": "^6.8.0",
     "eslint-plugin-babel": "^5.3.0",

packages/kbn-analytics/package.json

@@ -17,6 +17,6 @@
     "@babel/cli": "^7.8.4",
     "@kbn/dev-utils": "1.0.0",
     "@kbn/babel-preset": "1.0.0",
-    "typescript": "3.7.2"
+    "typescript": "3.9.3"
   }
 }

packages/kbn-babel-preset/common_preset.js

@@ -34,6 +34,10 @@ const plugins = [
   // Nullish coalescing proposal is stage 3 (https://github.com/tc39/proposal-nullish-coalescing)
   // Need this since we are using TypeScript 3.7+
   require.resolve('@babel/plugin-proposal-nullish-coalescing-operator'),
+
+  // Proposal is on stage 4 (https://github.com/tc39/proposal-export-ns-from)
+  // Need this since we are using TypeScript 3.8+
+  require.resolve('@babel/plugin-proposal-export-namespace-from'),
 ];
 
 module.exports = {

packages/kbn-babel-preset/package.json

@@ -5,6 +5,7 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@babel/plugin-proposal-class-properties": "^7.8.3",
+    "@babel/plugin-proposal-export-namespace-from": "^7.10.1",
     "@babel/plugin-proposal-nullish-coalescing-operator": "^7.8.3",
     "@babel/plugin-proposal-optional-chaining": "^7.9.0",
     "@babel/preset-env": "^7.9.0",

packages/kbn-config-schema/package.json

@@ -10,7 +10,7 @@
     "kbn:bootstrap": "yarn build"
   },
   "devDependencies": {
-    "typescript": "3.7.2"
+    "typescript": "3.9.3"
   },
   "peerDependencies": {
     "joi": "^13.5.2",

packages/kbn-dev-utils/package.json

@@ -20,10 +20,10 @@
     "moment": "^2.24.0",
     "rxjs": "^6.5.3",
     "tree-kill": "^1.2.2",
-    "tslib": "^1.9.3"
+    "tslib": "^2.0.0"
   },
   "devDependencies": {
-    "typescript": "3.7.2",
+    "typescript": "3.9.3",
     "@kbn/expect": "1.0.0",
     "chance": "1.0.18"
   }

packages/kbn-i18n/package.json

@@ -21,7 +21,7 @@
     "del": "^5.1.0",
     "getopts": "^2.2.4",
     "supports-color": "^7.0.0",
-    "typescript": "3.7.2"
+    "typescript": "3.9.3"
   },
   "dependencies": {
     "intl-format-cache": "^2.1.0",

packages/kbn-plugin-helpers/package.json

@@ -37,7 +37,7 @@
     "@types/through2": "^2.0.35",
     "@types/through2-map": "^3.0.0",
     "@types/vinyl": "^2.0.4",
-    "typescript": "3.7.2"
+    "typescript": "3.9.3"
   },
   "peerDependencies": {
     "@kbn/babel-preset": "1.0.0"

packages/kbn-pm/package.json

@@ -62,14 +62,14 @@
     "strip-ansi": "^4.0.0",
     "strong-log-transformer": "^2.1.0",
     "tempy": "^0.3.0",
-    "typescript": "3.7.2",
+    "typescript": "3.9.3",
     "unlazy-loader": "^0.1.3",
     "webpack": "^4.41.5",
     "webpack-cli": "^3.3.10",
     "wrap-ansi": "^3.0.1",
     "write-pkg": "^4.0.0"
   },
   "dependencies": {
-    "tslib": "^1.9.3"
+    "tslib": "^2.0.0"
   }
 }

src/core/index.ts

@@ -16,7 +16,5 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import * as Public from './public';
-import * as Server from './server';
-
-export { Public, Server };
+export * as Public from './public';
+export * as Server from './server';

src/core/server/server.ts

@@ -76,7 +76,7 @@ export class Server {
   private readonly status: StatusService;
   private readonly coreApp: CoreApp;
 
-  private pluginsInitialized?: boolean;
+  #pluginsInitialized?: boolean;
   private coreStart?: InternalCoreStart;
 
   constructor(
@@ -179,7 +179,7 @@ export class Server {
     };
 
     const pluginsSetup = await this.plugins.setup(coreSetup);
-    this.pluginsInitialized = pluginsSetup.initialized;
+    this.#pluginsInitialized = pluginsSetup.initialized;
 
     await this.legacy.setup({
       core: { ...coreSetup, plugins: pluginsSetup, rendering: renderingSetup },
@@ -198,7 +198,7 @@ export class Server {
     const elasticsearchStart = await this.elasticsearch.start();
     const savedObjectsStart = await this.savedObjects.start({
       elasticsearch: elasticsearchStart,
-      pluginsInitialized: this.pluginsInitialized,
+      pluginsInitialized: this.#pluginsInitialized,
     });
     const capabilitiesStart = this.capabilities.start();
     const uiSettingsStart = await this.uiSettings.start();

src/dev/i18n/extractors/code.js

@@ -76,6 +76,7 @@ export function* extractCodeMessages(buffer, reporter) {
         'dynamicImport',
         'nullishCoalescingOperator',
         'optionalChaining',
+        'exportNamespaceFrom',
       ],
     });
   } catch (error) {

src/plugins/console/server/lib/spec_definitions/js/globals.ts

@@ -57,7 +57,6 @@ export const globals = (specService: SpecDefinitionsService) => {
     fields: {
       '{field}': {
         fragment_size: 20,
-        number_of_fragments: 3,
         ...highlightOptions,
       },
     },

src/plugins/dashboard/public/application/lib/migrate_app_state.ts

@@ -39,7 +39,7 @@ import {
  * Once we hit a major version, we can remove support for older style URLs and get rid of this logic.
  */
 export function migrateAppState(
-  appState: { [key: string]: unknown } & DashboardAppState,
+  appState: { [key: string]: any } & DashboardAppState,
   kibanaVersion: string,
   usageCollection?: UsageCollectionSetup
 ): DashboardAppState {

src/plugins/dashboard/public/application/test_helpers/get_sample_dashboard_input.ts

@@ -57,8 +57,6 @@ export function getSampleDashboardPanel<TEmbeddableInput extends EmbeddableInput
       y: 0,
       i: overrides.explicitInput.id,
     },
-    type: overrides.type,
-    explicitInput: overrides.explicitInput,
     ...overrides,
   };
 }

src/plugins/data/public/search/legacy/fetch_soon.ts

@@ -41,7 +41,7 @@ export async function fetchSoon(
  * @param ms The number of milliseconds to wait
  * @return Promise<any> A promise that resolves with the result of executing the function
  */
-function delay(fn: Function, ms: number) {
+function delay<T>(fn: (...args: any) => T, ms: number): Promise<T> {
   return new Promise((resolve) => {
     setTimeout(() => resolve(fn()), ms);
   });
@@ -74,7 +74,7 @@ async function delayedFetch(
   const i = requestsToFetch.length;
   requestsToFetch = [...requestsToFetch, request];
   requestOptions = [...requestOptions, options];
-  const responses = await (fetchInProgress =
+  const responses: SearchResponse[] = await (fetchInProgress =
     fetchInProgress ||
     delay(() => {
       const response = callClient(requestsToFetch, requestOptions, fetchHandlers);

src/plugins/embeddable/public/lib/embeddables/with_subscription.tsx

@@ -68,12 +68,7 @@ export const withEmbeddableSubscription = <
 
     render() {
       return (
-        <WrappedComponent
-          input={this.state.input}
-          output={this.state.output}
-          embeddable={this.props.embeddable}
-          {...this.props}
-        />
+        <WrappedComponent input={this.state.input} output={this.state.output} {...this.props} />
       );
     }
   };

src/plugins/es_ui_shared/static/forms/components/fields/select_field.tsx

@@ -53,7 +53,6 @@ export const SelectField = ({ field, euiFieldProps, ...rest }: Props) => {
         onChange={(e) => {
           field.setValue(e.target.value);
         }}
-        options={[]}
         hasNoInitialSelection={true}
         isInvalid={isInvalid}
         data-test-subj="select"

src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts

@@ -320,7 +320,7 @@ export const useField = <T>(
       validationTypeToValidate: validationType,
     });
 
-    if ((validationErrors as Promise<ValidationError[]>).then) {
+    if (Reflect.has(validationErrors, 'then')) {
       return (validationErrors as Promise<ValidationError[]>).then(onValidationErrors);
     }
     return onValidationErrors(validationErrors as ValidationError[]);

src/plugins/telemetry/server/telemetry_repository/get_telemetry_saved_object.ts

@@ -28,7 +28,7 @@ export const getTelemetrySavedObject: GetTelemetrySavedObject = async (
   repository: SavedObjectsClientContract
 ) => {
   try {
-    const { attributes } = await repository.get('telemetry', 'telemetry');
+    const { attributes } = await repository.get<TelemetrySavedObject>('telemetry', 'telemetry');
     return attributes;
   } catch (error) {
     if (SavedObjectsErrorHelpers.isNotFoundError(error)) {

src/plugins/vis_type_timelion/public/components/panel.tsx

@@ -70,18 +70,18 @@ const emptyCaption = '<br>';
 function Panel({ interval, seriesList, renderComplete }: PanelProps) {
   const kibana = useKibana<TimelionVisDependencies>();
   const [chart, setChart] = useState(() => cloneDeep(seriesList.list));
-  const [canvasElem, setCanvasElem] = useState();
-  const [chartElem, setChartElem] = useState();
+  const [canvasElem, setCanvasElem] = useState<JQuery<HTMLElement>>();
+  const [chartElem, setChartElem] = useState<JQuery<HTMLElement>>();
 
   const [originalColorMap, setOriginalColorMap] = useState(() => new Map<Series, string>());
 
   const [highlightedSeries, setHighlightedSeries] = useState<number | null>(null);
-  const [focusedSeries, setFocusedSeries] = useState();
-  const [plot, setPlot] = useState();
+  const [focusedSeries, setFocusedSeries] = useState<number | null>();
+  const [plot, setPlot] = useState<jquery.flot.plot>();
 
   // Used to toggle the series, and for displaying values on hover
-  const [legendValueNumbers, setLegendValueNumbers] = useState();
-  const [legendCaption, setLegendCaption] = useState();
+  const [legendValueNumbers, setLegendValueNumbers] = useState<JQuery<HTMLElement>>();
+  const [legendCaption, setLegendCaption] = useState<JQuery<HTMLElement>>();
 
   const canvasRef = useCallback((node) => {
     if (node !== null) {
@@ -248,20 +248,20 @@ function Panel({ interval, seriesList, renderComplete }: PanelProps) {
     (pos: Position) => {
       unhighlightSeries();
 
-      const axes = plot.getAxes();
-      if (pos.x < axes.xaxis.min || pos.x > axes.xaxis.max) {
+      const axes = plot!.getAxes();
+      if (pos.x < axes.xaxis.min! || pos.x > axes.xaxis.max!) {
         return;
       }
 
-      const dataset = plot.getData();
+      const dataset = plot!.getData();
       if (legendCaption) {
         legendCaption.text(
           moment(pos.x).format(get(dataset, '[0]._global.legend.timeFormat', DEFAULT_TIME_FORMAT))
         );
       }
       for (let i = 0; i < dataset.length; ++i) {
         const series = dataset[i];
-        const useNearestPoint = series.lines.show && !series.lines.steps;
+        const useNearestPoint = series.lines!.show && !series.lines!.steps;
         const precision = get(series, '_meta.precision', 2);
 
         if (series._hide) {
@@ -281,14 +281,16 @@ function Panel({ interval, seriesList, renderComplete }: PanelProps) {
 
         const y = currentPoint[1];
 
-        if (y != null && legendValueNumbers) {
-          let label = y.toFixed(precision);
-          if (series.yaxis.tickFormatter) {
-            label = series.yaxis.tickFormatter(Number(label), series.yaxis);
+        if (legendValueNumbers) {
+          if (y == null) {
+            legendValueNumbers.eq(i).empty();
+          } else {
+            let label = y.toFixed(precision);
+            if (series.yaxis.tickFormatter) {
+              label = series.yaxis.tickFormatter(Number(label), series.yaxis);
+            }
+            legendValueNumbers.eq(i).text(`(${label})`);
           }
-          legendValueNumbers.eq(i).text(`(${label})`);
-        } else {
-          legendValueNumbers.eq(i).empty();
         }
       }
     },
@@ -308,7 +310,7 @@ function Panel({ interval, seriesList, renderComplete }: PanelProps) {
     if (legendCaption) {
       legendCaption.html(emptyCaption);
     }
-    each(legendValueNumbers, (num: Node) => {
+    each(legendValueNumbers!, (num: Node) => {
       $(num).empty();
     });
   }, [legendCaption, legendValueNumbers]);

test/common/services/security/test_user.ts

@@ -31,9 +31,9 @@ export async function createTestUserService(
   const config = getService('config');
   // @ts-ignore browser service is not normally available in common.
   const browser: Browser | void = hasService('browser') && getService('browser');
-  const testSubjects: TestSubjects | void =
-    // @ts-ignore testSubject service is not normally available in common.
-    hasService('testSubjects') && getService('testSubjects');
+  const testSubjects: TestSubjects | undefined =
+    // testSubject service is not normally available in common.
+    hasService('testSubjects') ? (getService('testSubjects' as any) as TestSubjects) : undefined;
   const kibanaServer = getService('kibanaServer');
 
   const enabledPlugins = config.get('security.disableTestUser')

test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json

@@ -18,6 +18,6 @@
   },
   "devDependencies": {
     "@kbn/plugin-helpers": "9.0.2",
-    "typescript": "3.7.2"
+    "typescript": "3.9.3"
   }
 }

test/plugin_functional/plugins/core_app_status/package.json

@@ -12,6 +12,6 @@
     "build": "rm -rf './target' && tsc"
   },
   "devDependencies": {
-    "typescript": "3.7.2"
+    "typescript": "3.9.3"
   }
 }

test/plugin_functional/plugins/core_plugin_a/package.json

@@ -12,6 +12,6 @@
     "build": "rm -rf './target' && tsc"
   },
   "devDependencies": {
-    "typescript": "3.7.2"
+    "typescript": "3.9.3"
   }
 }

test/plugin_functional/plugins/core_plugin_appleave/package.json

@@ -12,6 +12,6 @@
     "build": "rm -rf './target' && tsc"
   },
   "devDependencies": {
-    "typescript": "3.7.2"
+    "typescript": "3.9.3"
   }
 }