-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): move bin scripts into build #67568
Merged
mistic
merged 4 commits into
elastic:master
from
mistic:move-dist-bin-scripts-into-build
Jun 4, 2020
Merged
chore(NA): move bin scripts into build #67568
mistic
merged 4 commits into
elastic:master
from
mistic:move-dist-bin-scripts-into-build
Jun 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
Team:Operations
Team label for Operations Team
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
v7.8.1
labels
May 27, 2020
Pinging @elastic/kibana-operations (Team:Operations) |
6 tasks
spalger
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbudz
approved these changes
May 28, 2020
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jun 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jun 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic
added a commit
that referenced
this pull request
Jun 5, 2020
mistic
added a commit
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.8.1
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That intends to move the bin scripts only used by the distributable into the build folder. We are doing this because after discussing with @tylersmalley having both
bin
andscripts
on the root of our repo often confuse people.We also realise when doing #62468 that not having those bin scripts at the root of the repo will help on our needs for that mentioned PR.