Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): move bin scripts into build #67568

Merged
merged 4 commits into from
Jun 4, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented May 27, 2020

That intends to move the bin scripts only used by the distributable into the build folder. We are doing this because after discussing with @tylersmalley having both bin and scripts on the root of our repo often confuse people.

We also realise when doing #62468 that not having those bin scripts at the root of the repo will help on our needs for that mentioned PR.

@mistic mistic added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.8.1 labels May 27, 2020
@mistic mistic requested a review from tylersmalley May 27, 2020 23:15
@mistic mistic requested a review from a team as a code owner May 27, 2020 23:15
@mistic mistic self-assigned this May 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic
Copy link
Member Author

mistic commented May 30, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Jun 1, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Jun 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 7201e9c into elastic:master Jun 4, 2020
mistic added a commit to mistic/kibana that referenced this pull request Jun 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic added a commit to mistic/kibana that referenced this pull request Jun 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@mistic
Copy link
Member Author

mistic commented Jun 4, 2020

7.x: 65a24ea
7.8: 4661afa

mistic added a commit that referenced this pull request Jun 5, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic added a commit that referenced this pull request Jun 5, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants