Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM][E2E] remove unnecessary video #67362

Merged
merged 2 commits into from
May 27, 2020
Merged

[APM][E2E] remove unnecessary video #67362

merged 2 commits into from
May 27, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented May 26, 2020 •
edited
Loading

Summary

This was cause unfortunately when merging #61803

@v1v v1v self-assigned this May 26, 2020
@v1v v1v added the automation label May 26, 2020
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@v1v v1v added the Feature:CI Continuous integration label May 26, 2020
@v1v v1v marked this pull request as ready for review May 26, 2020 15:57
@v1v v1v requested a review from a team as a code owner May 26, 2020 15:57
@v1v v1v added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels May 26, 2020
@sorenlouv
Copy link
Member

In https://github.com/elastic/kibana/pull/61803/files#diff-fe119f9127b6ae6ad35785ebac4a37ceR11 you enabled video recording
image

I think we either need to disable this again, or gitignore video files, else they'll keep coming back as we run the tests locally.

@v1v
Copy link
Member Author

v1v commented May 26, 2020

Indeed, either way, I'd say I prefer the video to be on, if required to debug what's going on, if no concerns I'll proceed with the .gitignore approach

@sorenlouv
Copy link
Member

if no concerns I'll proceed with the .gitignore approach

sgtm 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@v1v v1v changed the title ci: remove unneccesary video ci: remove unnecessary video May 27, 2020
@v1v v1v changed the title ci: remove unnecessary video [APM][E2E] remove unnecessary video May 27, 2020
@v1v v1v merged commit 3b10a8c into elastic:master May 27, 2020
@v1v v1v deleted the feature/remove-video branch May 27, 2020 10:13
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67362 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 29, 2020
@v1v v1v added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels May 29, 2020
@v1v v1v mentioned this pull request Jun 2, 2020
Merged
v1v added a commit that referenced this pull request Jun 3, 2020
@v1v
[7.x] [APM][E2E] remove unnecessary video (#67362) #67949
473ca5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

Assignees

@v1v v1v

Labels
automation backport:skip This commit does not require backporting Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v1v @elasticmachine @sorenlouv @kibanamachine @smith