Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for api authentication usage #66819

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

EricDavisX
Copy link
Contributor

Hi, if it is helpful, I put this up for review.

I'm uncertain if this is language we would want to keep, butt, even as a new Elastic employee, and a junior API user, this confused me when I tried to use Kibana via API so it seemed a spot we could try to improve. I expect we wish to avoid citation of specific HTTP tools, which I understand but this is an attempt to inform users as possible.

Checklist

The only checklist item I think might be internationalization. ...I don't know how to i18n this, but am happy to research and add it if the base English text is deemed acceptable.

For maintainers

n/a

I'm uncertain if this is an appropriate doc note to add.  But, even as a new Elastic employee, this confused me when I tried to use the API so it seemed a spot we could try to improve.  I expect we wish to avoid citation of specific HTTP tools, which I understand but this is an attempt to inform users as possible.
@EricDavisX EricDavisX changed the title Update on api authentication usage Update docs for api authentication usage May 15, 2020
@EricDavisX EricDavisX added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels May 18, 2020
@EricDavisX EricDavisX requested a review from LeeDr May 18, 2020 22:05
@EricDavisX
Copy link
Contributor Author

Adding @LeeDr in for seniority QA opinion, do you think this is a useful API usage addition?

@LeeDr
Copy link

LeeDr commented May 19, 2020

Adding a link to the master docs for reference; https://www.elastic.co/guide/en/kibana/master/using-api.html

I see the example shows passing the username and password;

curl -X POST -u $USER:$PASSWORD "localhost:5601/api/kibana...

But I guess the part you're trying to elaborate on is that some specific tools may have an option for "basic authentication".

We usually only show examples in curl, so I would tend to not add something like this in the docs. The other issue is that Kibana also supports SAML, PKI, and other authentication mechanisms https://www.elastic.co/guide/en/kibana/master/kibana-authentication.html
So I'm concerned that all our existing curl examples only show basic auth.

@EricDavisX
Copy link
Contributor Author

EricDavisX commented May 20, 2020

Thanks so much for the time Lee. I think it could be helpful as is, but I totally see its a little out of the normal. If we choose to close this down, no harm no worries. Just glad to ask and help with ideas.

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small change, but otherwise, LGTM!

docs/api/using-api.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@EricDavisX EricDavisX merged commit 7b74094 into master Jul 2, 2020
@EricDavisX EricDavisX deleted the EricDavisX-docs-api-auth-enhancement branch July 2, 2020 11:55
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 2, 2020
* master:
  Update known-plugins.asciidoc (elastic#69370)
  [ML] Anomaly Explorer swim lane pagination (elastic#70063)
  [Ingest Manager] Update asset paths to use _ instead of - (elastic#70320)
  Fix discover, tsvb and Lens chart theming issues (elastic#69695)
  Allow Saved Object type mappings to set a field's `doc_values` property (elastic#70433)
  [S&R] Support data streams (elastic#68078)
  [Maps] Add styling and tooltip support to mapbox mvt vector tile sources (elastic#64488)
  redirect to default app if hash can not be forwarded (elastic#70417)
  [APM] Don't fetch dynamic index pattern in setupRequest (elastic#70308)
  [Security_Solution][Endpoint] Leveraging msearch and ancestry array for resolver (elastic#70134)
  Update docs for api authentication usage (elastic#66819)
  chore(NA): disable alerts_detection_rules cypress suites (elastic#70577)
  add getVisibleTypes API to SO type registry (elastic#70559)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 6, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66819 or prevent reminders by adding the backport:skip label.

5 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66819 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66819 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66819 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66819 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66819 or prevent reminders by adding the backport:skip label.

@EricDavisX EricDavisX added the backport:skip This commit does not require backporting label Jul 13, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants