Added console definitions for OSS. #66630
Conversation
|
First commit has been tested. Everything looks good for OSS. Moving on to X-pack. After that, we will need to include #66038 for transforms. Those will need to be manually overridden. |
|
This has been tested on 7.8. As far as I could find, all autocompletions work.. Also updated transforms via overrides and that works too. |
jloleysens
added
the
release_note:skip
There was a problem hiding this comment.
@cuff-links this is looking really great!
One thing that needs to be checked, however, is that we add overrides for the data_autocomplete_rules. These contain the manually added spec that we get from ES docs site. For instance the new searchable_snapshots.mount.json endpoint is a POST that should offer the following body completions: https://www.elastic.co/guide/en/elasticsearch/reference/master/searchable-snapshots-api-mount-snapshot.html#searchable-snapshots-api-mount-request-body.
Do you think you could take a look at all of the newly added endpoints to make sure their body completions are added?
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…-links/kibana into Updated_Console_Spec_ES_Definitions
|
@jloleysens I think we are in good shape now. |
There was a problem hiding this comment.
Great job @cuff-links , I think this is exactly where we want to be.
Running locally, however, I noticed that autocomplete was not working. It looks like the issue was coming from the change:
...
"settings": {
"docs_per_second": null,
"max_page_search_size": 500
},
...Which was making the objects not traversable by the autocomplete system. I applied this commit 4e58b6d to the branch.
Check it out, if you're happy you can go ahead and merge.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
These are the updated console definitions for OSS and X-Pack ensuring that the autocomplete in Kibana maps to the correct endpoints.