Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Add create template button #66613

Merged
merged 51 commits into from
Jun 9, 2020
Merged

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented May 14, 2020

Summary

This PR is to add create template timeline button.
To verify this PR please go to x-pack/plugins/siem/common/constants.ts Line 149 and change disableTemplate into false;

Screenshot 2020-06-02 at 16 53 06

Screenshot 2020-06-02 at 16 52 53

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@angorayc angorayc added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels May 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@angorayc angorayc added v7.9.0 and removed v7.8.0 labels May 17, 2020
@angorayc angorayc marked this pull request as ready for review May 18, 2020 14:27
@angorayc angorayc requested review from a team as code owners May 18, 2020 14:27
@angorayc angorayc force-pushed the template-btn branch 2 times, most recently from 10ccac0 to 38686d7 Compare May 28, 2020 21:15
@angorayc
Copy link
Contributor Author

angorayc commented Jun 1, 2020

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

angorayc commented Jun 4, 2020

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

angorayc commented Jun 5, 2020

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

angorayc commented Jun 5, 2020

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

angorayc commented Jun 8, 2020

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As we have discussed let's have it merged and any findings are going to fixed in #67837

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit 88f252a into elastic:master Jun 9, 2020
angorayc added a commit to angorayc/kibana that referenced this pull request Jun 9, 2020
* add template btn

* rename file

* unit test

* replace connector with useDispatch

* comments

* add disableTemplate

* rename flag

* fix types

* remove snapshot

* fix types

* add fix action

* move disableTemplate flag into constants

* fix types

* Fix timelineType

* button style

* unit test

* unit test

* fix types

* Update x-pack/plugins/siem/public/timelines/components/timeline/properties/create_timeline_btn.tsx

Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>

* fix unit test

* add unit test

* add unit test

* fix types

* fix tests

* fix unit

* fix i18n key

* remove snapshot

* fix crud

* fix crud

* fix unit

* fix tag

* fix unit

* disable template timeline

* Update use_create_timeline.tsx

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
angorayc added a commit that referenced this pull request Jun 9, 2020
* add template btn

* rename file

* unit test

* replace connector with useDispatch

* comments

* add disableTemplate

* rename flag

* fix types

* remove snapshot

* fix types

* add fix action

* move disableTemplate flag into constants

* fix types

* Fix timelineType

* button style

* unit test

* unit test

* fix types

* Update x-pack/plugins/siem/public/timelines/components/timeline/properties/create_timeline_btn.tsx

Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>

* fix unit test

* add unit test

* add unit test

* fix types

* fix tests

* fix unit

* fix i18n key

* remove snapshot

* fix crud

* fix crud

* fix unit

* fix tag

* fix unit

* disable template timeline

* Update use_create_timeline.tsx

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 9, 2020
* master: (37 commits)
  [DOCS] Adds documentation for drilldowns (elastic#68122)
  [Telemetry] telemetry.sendUsageFrom: "server" by default (elastic#68071)
  [ML] Transforms: Support sub-aggregations (elastic#68306)
  Fixed pre-configured docs link points to the wrong page and functional tests configs (elastic#68606)
  [Ingest Manager] Update queries from `stream.*` to `dataset.*` (elastic#68322)
  Enable Watcher by default to fix bug in which Watcher doesn't render in the side nav (elastic#68602)
  Convert Index Templates API routes to snakecase. (elastic#68463)
  [SECURITY SOLUTION] [Detections] Add / Update e2e tests to ensure initial rule runs are successful (elastic#68441)
  [Ingest] OpenAPI spec file (elastic#68323)
  chore(NA): skip apis Endpoint plugin Endpoint policy api (elastic#68638)
  bumping makelogs version to v6.0.0 (elastic#66163)
  [SIEM] Add create template button (elastic#66613)
  Bump websocket-extensions from 0.1.3 to 0.1.4 (elastic#68414)
  [ML] Sample data modules - use event.dataset instead of index name (elastic#68538)
  [ML] Functional tests - fix job validation API test with maxModelMemoryLimit (elastic#68501)
  [ML] Functional tests - stabilize DFA job creation (elastic#68495)
  [TSVB] Allows the user to change the tooltip mode (elastic#67775)
  chore(NA): skip apis Endpoint plugin Endpoint alert API when data is in elasticsearch (elastic#68613)
  chore(NA): skip endpoint Endpoint Alert Page: when es has data and user has navigated to the page (elastic#68596)
  [SIEM][Detection Engine] Converts from joi to use io-ts and moves the types to common  (elastic#68127)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants