Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fixes add page CSS animation bug #66496

Merged
merged 4 commits into from
May 21, 2020
Merged

[Canvas] Fixes add page CSS animation bug #66496

merged 4 commits into from
May 21, 2020

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented May 13, 2020 •
edited
Loading

Summary

This fixes a Chrome visual bug with the add page button disappearing. This is due to a conflict between our custom CSS animations and EUI focus animations on buttons. By adding the kbn-resetFocusState class to the add page button, EUI animations won't be applied.

Before:
May-13-2020 11-24-55

After:
canvas-add-pages

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 added bug Fixes for quality problems that affect the customer experience review release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.8.0 v7.7.1 labels May 13, 2020
@cqliu1 cqliu1 requested a review from a team as a code owner May 13, 2020 22:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@cqliu1
Copy link
Contributor Author

cqliu1 commented May 15, 2020

@elasticmachine merge upstream

@cqliu1
Copy link
Contributor Author

cqliu1 commented May 18, 2020

@elasticmachine merge upstream

@cqliu1
Copy link
Contributor Author

cqliu1 commented May 21, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit 90cabae into elastic:master May 21, 2020
@cqliu1 cqliu1 deleted the fix/add-page-button branch May 21, 2020 21:21
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request May 21, 2020
@cqliu1 @elasticmachine @tsullivan
Fixes add page animation bug (elastic#66496)
681aa02 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 66496 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 25, 2020
@cqliu1 cqliu1 removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 26, 2020
cqliu1 added a commit to cqliu1/kibana that referenced this pull request May 26, 2020
@cqliu1 @elasticmachine
Fixes add page animation bug (elastic#66496)
ee76a73 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@cqliu1 cqliu1 mentioned this pull request May 26, 2020
Merged
This was referenced May 26, 2020
Merged
Merged
cqliu1 added a commit to cqliu1/kibana that referenced this pull request May 26, 2020
@cqliu1 @elasticmachine
Fixes add page animation bug (elastic#66496)
4882c21 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@cqliu1 cqliu1 added the v7.9.0 label May 26, 2020
cqliu1 added a commit that referenced this pull request May 26, 2020
@cqliu1 @elasticmachine
[7.8] Fixes add page animation bug (#66496) (#67367)
eb225c6 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cqliu1 added a commit that referenced this pull request May 27, 2020
@cqliu1 @elasticmachine
Fixes add page animation bug (#66496) (#67410)
79278c7 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cqliu1 added a commit to cqliu1/kibana that referenced this pull request May 27, 2020
@cqliu1
Fixes add page animation bug (elastic#66496)
830aede 
    Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 27, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

cqliu1 added a commit that referenced this pull request May 28, 2020
@cqliu1 @elasticmachine
[7.7] Fixes add page animation bug (#66496) (#67369)
ec9c1e5 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:fix review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.7.1 v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cqliu1 @elasticmachine @kibanamachine @crob611