Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate security and spaces integration test plugins to Kibana Platform #66415

Merged
merged 4 commits into from
May 13, 2020
Merged

Migrate security and spaces integration test plugins to Kibana Platform #66415

merged 4 commits into from
May 13, 2020

Conversation

jportner
Copy link
Contributor

Resolves #66057.

@jportner jportner added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels May 13, 2020
@jportner jportner requested a review from azasypkin May 13, 2020 14:16
@azasypkin
Copy link
Member

ACK: will review today

Btw it seems eslint task is failing....

@jportner
Delete vestigial legacy plugin files
162ec8e 
The cherry-pick of the prior commit  missed these.
azasypkin
azasypkin approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

.../test/saved_object_api_integration/common/fixtures/saved_object_test_plugin/server/plugin.ts Outdated Show resolved Hide resolved
.../test/saved_object_api_integration/common/fixtures/saved_object_test_plugin/server/plugin.ts Outdated Show resolved Hide resolved
.../saved_object_api_integration/common/fixtures/namespace_agnostic_type_plugin/server/index.ts
},
});

plugins.features.registerFeature({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I see we don't do this in a new plugin, we don't need this anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. No, we don't need it for saved object API integration tests.

I looked at the history and it was originally added during #31652, which was a huge PR. My guess is it was a WIP for feature integration tests that were never completed, or it was leftover cruft that was copied from another test plugin, or there were feature integration tests here that got refactored out later on. In any case, we should be safe to remove it here (CI will confirm!)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit 9186133 into elastic:master May 13, 2020
@jportner jportner deleted the migrate-security-test-plugins branch May 13, 2020 20:08
@jportner jportner mentioned this pull request May 13, 2020
Merged
jportner added a commit to jportner/kibana that referenced this pull request May 13, 2020
@jportner
Migrate security and spaces integration test plugins to Kibana Platfo…
45f0956 
…rm (elastic#66415)
jportner added a commit that referenced this pull request May 14, 2020
@jportner
[7.x] Migrate security and spaces integration test plugins to Kibana …
f32f1de 
…Platform (#66415) (#66470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Security test plugins to KP
3 participants
@jportner @azasypkin @kibanamachine