[Lens] fix empty state for pie #66206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
We already have custom chart type icons for Lens in the chart type switcher. I'd rather not add more glyphs as well for every chart type. I would have thought we'd just use a simple chart icon for every type of chart for all empty states. I'll consider what this should be. |
flash1293
approved these changes
May 12, 2020
cchaos
approved these changes
May 12, 2020
There was a problem hiding this comment.
I just realized you're trying to get this into 7.8. I think it's fine for now to ship with the pie chart icon for donut and treemaps. I'll continue to think on this state for 7.9.
The screenshots LGTM, though I didn't test locally. Thanks for getting it in so quickly!
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
May 13, 2020
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
May 13, 2020
v1v
added a commit
to v1v/kibana
that referenced
this pull request
May 13, 2020
* upstream/master: (223 commits) [Ingest] Support root level yaml variables in agent stream template (elastic#66120) [Snapshot Restore] Fix error when deleting snapshots behind reverse proxy (elastic#66147) [Lens] fix empty state for pie (elastic#66206) [APM] Improve e2e tests (elastic#66373) [ML] Data Frame Analytics: Fix steps to be named phases. (elastic#65855) [Discover] Encode context link filter part (elastic#63831) [APM] Scope APM alert creation to environment (elastic#65681) Move Kibana Usage collectors outside the telemetry plugin (elastic#65663) [ML] Data Frame Analytics: Fix confusion matrix data grid width. (elastic#65818) Switch to core application service (elastic#63443) Removes use of prefer_v2_templates (elastic#66316) [Maps] handle case where fit to bounds does not match any documents (elastic#66307) log error instead of throw (elastic#66254) [plugin-helpers] remove outdated postinstall task (elastic#66324) Spaces - migrate default space and enter space view to KP (elastic#66098) [APM] Change plugin id for `apm_oss` to `apmOss` (elastic#66164) [Maps] convert map_selectors to TS (elastic#65905) [uptime/usage-collector] add missing await (elastic#66079) [Ingest] Add additional attributes to the Datasources Saved Object (elastic#66127) [Endpoint]EMT-339: add new policy response schema (elastic#66264) ...
mbondyra
added a commit
that referenced
this pull request
May 13, 2020
mbondyra
added a commit
that referenced
this pull request
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #65692
The PR
visPieto display the icon of pie chart no matter if it's pie, donut or treemap as this is the only one we have in EUI. @cchaos do you think it's worth to design the icons for donut and treemap?Checklist
Delete any items that are not applicable to this PR.
For maintainers