Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev Tools] Fix height calc in calc issue for ie11 #66010

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/plugins/console/public/styles/_app.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
// TODO: Move all of the styles here (should be modularised by, e.g., CSS-in-JS or CSS modules).
@import '@elastic/eui/src/components/header/variables';

// This value is calculated to static value using SCSS because calc in calc has issues in IE11
$headerHeightOffset: $euiHeaderHeightCompensation * 2;

#consoleRoot {
height: calc(100vh - calc(#{$euiHeaderChildSize} * 2));
height: calc(100vh - #{$headerHeightOffset});
display: flex;
flex: 1 1 auto;
// Make sure the editor actions don't create scrollbars on this container
Expand Down
7 changes: 5 additions & 2 deletions x-pack/plugins/painless_lab/public/styles/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* This is a very brittle way of preventing the editor and other content from disappearing
* behind the bottom bar.
*/
$bottomBarHeight: calc(#{$euiSize} * 3);
$bottomBarHeight: $euiSize * 3;

.painlessLabBottomBarPlaceholder {
height: $bottomBarHeight;
Expand Down Expand Up @@ -40,8 +40,11 @@ $bottomBarHeight: calc(#{$euiSize} * 3);
line-height: 0;
}

// This value is calculated to static value using SCSS because calc in calc has issues in IE11
$headerHeightOffset: $euiHeaderHeightCompensation * 2;

.painlessLabMainContainer {
height: calc(100vh - calc(#{$euiHeaderChildSize} * 2) - #{$bottomBarHeight});
height: calc(100vh - #{$headerHeightOffset} - #{$bottomBarHeight});
}

.painlessLabPanelsContainer {
Expand Down
5 changes: 4 additions & 1 deletion x-pack/plugins/searchprofiler/public/styles/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@
}
}

// This value is calculated to static value using SCSS because calc in calc has issues in IE11
$headerHeightOffset: $euiHeaderHeightCompensation * 2;

.appRoot {
height: calc(100vh - calc(#{$euiHeaderChildSize} * 2));
height: calc(100vh - #{$headerHeightOffset});
overflow: hidden;
flex-shrink: 1;
}
Expand Down