Lens editor auto refresh #65868
Merged
Lens editor auto refresh #65868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
Feature:Drilldowns
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@wylieconlon Suggestions also auto-reload now |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jun 3, 2020
flash1293
added a commit
that referenced
this pull request
Jun 3, 2020
pauldotpower
added
release highlight
release_note:breaking
release_note:deprecation
release_note:fix
release_note:plugin_api_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57671
This PR makes sure the lens visualization auto-refreshes when it is configured in the date picker.
To do so without completely unmounting the expression renderer component and thus recreating the expression loader instance, this PR introduces a new prop
refresh$on the expression renderer which allows to reload the expression without re-rendering the whole react tree.We can use the same mechanism in the Lens embeddable, but I would like to do that separately.