Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drilldowns] Copy improvements #65838

Merged
merged 4 commits into from
May 11, 2020
Merged

[Drilldowns] Copy improvements #65838

merged 4 commits into from
May 11, 2020
+43 −46

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented May 8, 2020

Summary

Closes #65084

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@Dosant Dosant added v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes Feature:Drilldowns Embeddable panel Drilldowns v7.9.0 labels May 8, 2020
@Dosant Dosant requested a review from a team as a code owner May 8, 2020 11:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant requested a review from streamich May 8, 2020 11:30
@Dosant Dosant added the chore label May 8, 2020
@streamich streamich mentioned this pull request May 8, 2020
Closed
5 tasks
@Dosant Dosant closed this May 8, 2020
@Dosant Dosant deleted the dev/drilldowns-copy-update branch May 8, 2020 13:25
@Dosant Dosant restored the dev/drilldowns-copy-update branch May 8, 2020 13:43
@Dosant Dosant reopened this May 8, 2020
@Dosant
Copy link
Contributor Author

Dosant commented May 11, 2020

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented May 11, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit ae38c6b into elastic:master May 11, 2020
@Dosant Dosant deleted the dev/drilldowns-copy-update branch May 11, 2020 10:38
Dosant added a commit to Dosant/kibana that referenced this pull request May 11, 2020
@Dosant @elasticmachine
[Drilldowns] Copy improvements (elastic#65838)
b6d56bc 
* update toast messages

* update HelloBar text

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Dosant Dosant mentioned this pull request May 11, 2020
Merged
Dosant added a commit that referenced this pull request May 12, 2020
@Dosant @elasticmachine
[Drilldowns] Copy improvements (#65838) (#65994)
a490680 
* update toast messages

* update HelloBar text

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
chore Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Drilldowns] Text suggestions
4 participants
@Dosant @elasticmachine @kibanamachine @streamich