Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drilldowns][IE] fix welcome bar layout in IE #65676

Merged
merged 9 commits into from
May 12, 2020
Merged

[Drilldowns][IE] fix welcome bar layout in IE #65676

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ba5708b
fix drilldown hello bar in IE
Dosant May 7, 2020
0d5d2b7
fix comment
Dosant May 7, 2020
aa53043
Merge branch 'master' into dev/fix-drildowns-welcome-in-ie
elasticmachine May 7, 2020
402c421
Merge branch 'master' of github.com:elastic/kibana into dev/fix-drild…
Dosant May 8, 2020
2f0eee2
use children instead of title for EuiCallOut content
Dosant May 8, 2020
b2a7b82
Merge branch 'master' into dev/fix-drildowns-welcome-in-ie
elasticmachine May 8, 2020
1e4db0a
Merge branch 'master' into dev/fix-drildowns-welcome-in-ie
elasticmachine May 8, 2020
5f24ab5
Merge branch 'master' into dev/fix-drildowns-welcome-in-ie
elasticmachine May 11, 2020
f79887d
Merge branch 'master' into dev/fix-drildowns-welcome-in-ie
elasticmachine May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 25 additions & 28 deletions x-pack/plugins/drilldowns/public/components/drilldown_hello_bar/drilldown_hello_bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,33 +30,30 @@ export const DrilldownHelloBar: React.FC<DrilldownHelloBarProps> = ({
onHideClick = () => {},
}) => {
return (
<EuiCallOut
data-test-subj={WELCOME_MESSAGE_TEST_SUBJ}
title={
<EuiFlexGroup className="drdHelloBar__content">
<EuiFlexItem grow={false}>
<div style={{ marginLeft: '8px' }}>
<EuiIcon type="help" />
</div>
</EuiFlexItem>
<EuiFlexItem grow={true}>
<EuiText size={'s'}>
<EuiTextColor color="subdued">{txtHelpText}</EuiTextColor>
</EuiText>
{docsLink && (
<>
<EuiSpacer size={'xs'} />
<EuiLink href={docsLink}>{txtViewDocsLinkLabel}</EuiLink>
</>
)}
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty size="xs" onClick={onHideClick}>
{txtHideHelpButtonLabel}
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
}
/>
<EuiCallOut data-test-subj={WELCOME_MESSAGE_TEST_SUBJ}>
<EuiFlexGroup>
<EuiFlexItem grow={false}>
<div style={{ marginLeft: '8px' }}>
<EuiIcon type="help" />
</div>
</EuiFlexItem>
<EuiFlexItem grow={1}>
<EuiText size={'s'}>
<EuiTextColor color="subdued">{txtHelpText}</EuiTextColor>
</EuiText>
{docsLink && (
<>
<EuiSpacer size={'xs'} />
<EuiLink href={docsLink}>{txtViewDocsLinkLabel}</EuiLink>
</>
)}
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty size="xs" onClick={onHideClick}>
{txtHideHelpButtonLabel}
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiCallOut>
);
};