Add cloud icon for supported settings and embed single-sourced getting started #65610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-docs (Team:Docs) |
KOTungseth
approved these changes
May 7, 2020
KOTungseth
added
release_note:skip
KOTungseth
reviewed
May 7, 2020
KOTungseth
reviewed
May 7, 2020
docs/setup/settings.asciidoc
Outdated
| @@ -349,11 +349,11 @@ layer option list. Supported on {ece}. By turning this off, | |||
| only the layers that are configured here will be included. The default is `true`. | |||
| This also affects whether tile-service from the Elastic Maps Service will be available. | |||
|
|
|||
| | [[regionmap-attribution]] `map.regionmap.layers[].attribution:` | |||
| | [[regionmap-attribution]] `map.regionmap.layers[].attribution:` {ess-icon} | |||
| | Optional. References the originating source of the geojson file. | |||
| Supported on {ece}. | |||
There was a problem hiding this comment.
This setting is also supported on ECE.
KOTungseth
reviewed
May 7, 2020
KOTungseth
reviewed
May 7, 2020
KOTungseth
reviewed
May 7, 2020
docs/setup/settings.asciidoc
Outdated
| | Mandatory. | ||
| This value is used to do an inner-join between the document stored in | ||
| {es} and the geojson file. For example, if the field in the geojson is | ||
| called `Location` and has city names, there must be a field in {es} | ||
| that holds the same values that {kib} can then use to lookup for the geoshape | ||
| data. Supported on {ece}. | ||
|
|
||
| | [[regionmap-name]] `map.regionmap.layers[].name:` | ||
| | [[regionmap-name]] `map.regionmap.layers[].name:` {ess-icon} | ||
| | Mandatory. A description of | ||
| the map being provided. Supported on {ece}. |
There was a problem hiding this comment.
This setting is also supported on ECE.
KOTungseth
reviewed
May 7, 2020
KOTungseth
reviewed
May 7, 2020
KOTungseth
reviewed
May 7, 2020
docs/setup/settings.asciidoc
Outdated
| | The map attribution string. Supported on {ece}. | ||
| *Default: `"© [Elastic Maps Service](https://www.elastic.co/elastic-maps-service)"`* | ||
|
|
||
| | [[tilemap-max-zoom]] `map.tilemap.options.maxZoom:` | ||
| | [[tilemap-max-zoom]] `map.tilemap.options.maxZoom:` {ess-icon} | ||
| | The maximum zoom level. Supported on {ece}. *Default: `10`* |
There was a problem hiding this comment.
This setting is also supported on ECE.
KOTungseth
reviewed
May 7, 2020
KOTungseth
reviewed
May 7, 2020
KOTungseth
reviewed
May 7, 2020
docs/setup/settings.asciidoc
Outdated
| | An array of subdomains | ||
| used by the tile service. Specify the position of the subdomain the URL with | ||
| the token `{s}`. Supported on {ece}. | ||
|
|
||
| | [[tilemap-url]] `map.tilemap.url:` | ||
| | [[tilemap-url]] `map.tilemap.url:` {ess-icon} | ||
| | The URL to the tileservice that {kib} uses | ||
| to display map tiles in tilemap visualizations. Supported on {ece}. By default, |
There was a problem hiding this comment.
This setting is also supported on ECE.
KOTungseth
reviewed
May 7, 2020
KOTungseth
reviewed
May 7, 2020
|
It looks like there are 13 settings that are supported on _ECE, not 4-5. |
nrichers
changed the title
14, actually? I found 13 if I searched with a space in front on |
|
With the additional ECE icon, this LGTM. I'd like final buy-in from @gchaps. |
|
Jenkins test this please |
nrichers
pushed a commit
to nrichers/kibana
that referenced
this pull request
May 14, 2020
…g started (elastic#65610) * Add cloud icon for supported settings * Remove delimited block from single-sourced content, edits * Remove delimited block from single-sourced content, edits * Remove ifeval to simplify life * Switch to docs-root * Add ECE icons
nrichers
pushed a commit
to nrichers/kibana
that referenced
this pull request
May 14, 2020
…g started (elastic#65610) * Add cloud icon for supported settings * Remove delimited block from single-sourced content, edits * Remove delimited block from single-sourced content, edits * Remove ifeval to simplify life * Switch to docs-root * Add ECE icons
nrichers
pushed a commit
to nrichers/kibana
that referenced
this pull request
May 14, 2020
…g started (elastic#65610) * Add cloud icon for supported settings * Remove delimited block from single-sourced content, edits * Remove delimited block from single-sourced content, edits * Remove ifeval to simplify life * Switch to docs-root * Add ECE icons
nrichers
pushed a commit
to nrichers/kibana
that referenced
this pull request
May 14, 2020
…g started (elastic#65610) * Add cloud icon for supported settings * Remove delimited block from single-sourced content, edits * Remove delimited block from single-sourced content, edits * Remove ifeval to simplify life * Switch to docs-root * Add ECE icons
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 15, 2020
…ent/add-support-in-url-for-hidden-toggle * 'master' of github.com:elastic/kibana: (34 commits) [SIEM][CASE] Fix bug when connector is deleted. (elastic#65876) [SIEM][CASE] Improve layout (elastic#66232) [Index Management] Support Hidden Indices (elastic#66422) Add Login Selector functional tests. (elastic#65705) Lens drilldowns (elastic#65675) [ML] Custom template for apiDoc markdown (elastic#66567) Don't bootstrap core type emits (elastic#66377) [Dashboard] Improve loading error handling (elastic#66372) [APM] Minor style fixes for the node strokes (elastic#66574) [Ingest Manager] Fix create data source from integration (elastic#66626) [Metrics UI] Fix default metric alert interval for new conditions (elastic#66610) [Metrics UI] Fix alignment and allow clearing metric value (elastic#66589) Don't return package name for non-package data streams (elastic#66606) [Ingest Manager] Consolidate routing and add breadcrumbs to all pages (elastic#66475) [Docs/Reporting] Have the docs about granular timeout match Cloud docs (elastic#66267) Don't automatically add license header to code inside plugins dir. (elastic#66601) [APM] Don't trigger map layout if no elements (elastic#66625) [Logs UI] Validate ML job setup time ranges (elastic#66426) Fix pagination bugs in CCR and Remote Clusters (elastic#65931) Add cloud icon for supported settings and embed single-sourced getting started (elastic#65610) ... # Conflicts: # x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js # x-pack/plugins/index_management/server/lib/fetch_indices.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Adds ESS and ECE cloud icons for Kibana settings that are supported on cloud. Since our cloud products support only a subset of the available Kibana settings, we need to indicate whether something is supported in the context of the Kibana docs. The icons are taken from our current marketing collateral and are in the SVG format to make sure they scale correctly.
Embeds single-sourced getting started content for cloud. This content is part of the cloud-first collateral we're providing to different teams and we're using it here for the first time, as requested by Kaarina.
Depends on elastic/docs#1815 to build.
Relates to the cloud-first effort currently underway tracked in the meta issue https://github.com/elastic/cloud/issues/48412.
Checklist
Delete any items that are not applicable to this PR.
For maintainers