Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement plugin config prefix #6554

Merged
merged 12 commits into from
Mar 23, 2016
Merged

Implement plugin config prefix #6554

merged 12 commits into from
Mar 23, 2016

Commits on Mar 16, 2016

  1. add support for a configPrefix setting 

    - switch from maps to objects
  - use lodash's get/set/has
- use configPrefix instead of id, if set
- also adds an unset config method
    @spalger @w33ble
    spalger authored and w33ble committed Mar 16, 2016
    Configuration menu
    Copy the full SHA
    c72c440 View commit details
    Browse the repository at this point in the history

  2. remove configPrefix from test_bundle

    @w33ble
    w33ble committed Mar 16, 2016
    Configuration menu
    Copy the full SHA
    c852844 View commit details
    Browse the repository at this point in the history

  3. restore the key validation

    @w33ble
    w33ble committed Mar 16, 2016
    Configuration menu
    Copy the full SHA
    5a488f4 View commit details
    Browse the repository at this point in the history

  4. add test for dot-notated config keys

    @w33ble
    w33ble committed Mar 16, 2016
    Configuration menu
    Copy the full SHA
    8790a79 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2016

  1. empty schema test is not async

    @w33ble
    w33ble committed Mar 17, 2016
    Configuration menu
    Copy the full SHA
    f7cc5f1 View commit details
    Browse the repository at this point in the history

  2. remove unused toPath

    @w33ble
    w33ble committed Mar 17, 2016
    Configuration menu
    Copy the full SHA
    765185f View commit details
    Browse the repository at this point in the history

  3. actually check object keys in schema

    @w33ble
    w33ble committed Mar 17, 2016
    Configuration menu
    Copy the full SHA
    96e5937 View commit details
    Browse the repository at this point in the history

  4. add some more tests around invalid config paths

    @w33ble
    w33ble committed Mar 17, 2016
    Configuration menu
    Copy the full SHA
    41e3081 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2016

  1. correctly use Joi.object().keys(), finally

    @w33ble
    w33ble committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    2152047 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2016

  1. move unset into its own module, include tests 

    also fixes issue with recursive removal of properties
    @w33ble
    w33ble committed Mar 22, 2016
    Configuration menu
    Copy the full SHA
    b126e35 View commit details
    Browse the repository at this point in the history

  2. use external unset module

    @w33ble
    w33ble committed Mar 22, 2016
    Configuration menu
    Copy the full SHA
    115128b View commit details
    Browse the repository at this point in the history

  3. use unset instead of delete, fixes schema bug

    @w33ble
    w33ble committed Mar 22, 2016
    Configuration menu
    Copy the full SHA
    2ebd94d View commit details
    Browse the repository at this point in the history