Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shallow clone properties when adding to alert or action registry #65309

Merged
merged 1 commit into from
May 6, 2020
Merged

Shallow clone properties when adding to alert or action registry #65309

merged 1 commit into from
May 6, 2020

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented May 5, 2020

In this PR, I'm making the alert and actions registry shallow clone objects when adding to their collection.

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 v7.7.1 labels May 5, 2020
@mikecote mikecote self-assigned this May 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote marked this pull request as ready for review May 5, 2020 19:20
@mikecote mikecote requested a review from a team as a code owner May 5, 2020 19:20
pmuellr
pmuellr approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YulNaumenko
YulNaumenko approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote merged commit b71b139 into elastic:master May 6, 2020
@mikecote mikecote added the v7.9.0 label May 6, 2020
@mikecote mikecote mentioned this pull request May 6, 2020
Merged
mikecote added a commit to mikecote/kibana that referenced this pull request May 6, 2020
@mikecote
Shallow clone properties when adding to registry (elastic#65309)
813c815
mikecote added a commit to mikecote/kibana that referenced this pull request May 6, 2020
@mikecote
Shallow clone properties when adding to registry (elastic#65309)
3bfd15d
@mikecote mikecote mentioned this pull request May 6, 2020
Merged
mikecote added a commit to mikecote/kibana that referenced this pull request May 6, 2020
@mikecote
Shallow clone properties when adding to registry (elastic#65309)
9a733a2
@mikecote mikecote mentioned this pull request May 6, 2020
Merged
mikecote added a commit that referenced this pull request May 7, 2020
@mikecote
Shallow clone properties when adding to registry (#65309) (#65525)
a6339e4
mikecote added a commit that referenced this pull request May 7, 2020
@mikecote
Shallow clone properties when adding to registry (#65309) (#65526)
dbcf3ff
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 7, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

mikecote added a commit that referenced this pull request May 14, 2020
@mikecote @elasticmachine
Shallow clone properties when adding to registry (#65309) (#65527)
b85146a 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 14, 2020
@mikecote mikecote mentioned this pull request Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@mikecote mikecote

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1 v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikecote @elasticmachine @kibanamachine @pmuellr @YulNaumenko