Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] NP Plugin dependency cleanup #64842

Merged
merged 7 commits into from
Apr 30, 2020
Merged

[SIEM] NP Plugin dependency cleanup #64842

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
687d301
Remove static src dependencies from kibana.json
rylnd Apr 28, 2020
809382a
Make usageCollection an optional dependency
rylnd Apr 29, 2020
b0da9f9
Remove unused plugin contracts
rylnd Apr 29, 2020
a71022f
Merge branch 'master' into siem_dependency_trimming
rylnd Apr 30, 2020
11f0662
Remove unnecessary try/catch
rylnd Apr 30, 2020
808b1b4
Improve typings of our Plugin classes
rylnd Apr 30, 2020
98e2cc3
Don't re-export core types
rylnd Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions x-pack/plugins/siem/kibana.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,22 @@
"alerting",
"data",
"embeddable",
"esUiShared",
"features",
"home",
"inspector",
"kibanaUtils",
"licensing",
"maps",
"triggers_actions_ui",
"uiActions",
"uiActions"
],
"optionalPlugins": [
"encryptedSavedObjects",
"ml",
"newsfeed",
"security",
"spaces",
"usageCollection"
],
"optionalPlugins": ["encryptedSavedObjects", "ml", "newsfeed", "security", "spaces"],
"server": true,
"ui": true
}
6 changes: 4 additions & 2 deletions x-pack/plugins/siem/public/lib/telemetry/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ export { METRIC_TYPE };

type TrackFn = (type: UiStatsMetricType, event: string | string[], count?: number) => void;

const noop = () => {};

let _track: TrackFn;

export const track: TrackFn = (type, event, count) => {
Expand All @@ -25,9 +27,9 @@ export const track: TrackFn = (type, event, count) => {

export const initTelemetry = (usageCollection: SetupPlugins['usageCollection'], appId: string) => {
try {
_track = usageCollection.reportUiStats.bind(null, appId);
_track = usageCollection?.reportUiStats.bind(null, appId) ?? noop;
} catch (error) {
// ignore failed setup here, as we'll just have an inert tracker
_track = noop;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this part of the exception be hit anymore? It doesn't seem like it with the way you changed it above. Just a question I have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar thought! Probably not, unless reportUiStats wasn't a function? I debated between the safety of the try/catch vs the cleanliness of not having it.

}
};

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/siem/public/plugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export interface SetupPlugins {
home: HomePublicPluginSetup;
security: SecurityPluginSetup;
triggers_actions_ui: TriggersActionsSetup;
usageCollection: UsageCollectionSetup;
usageCollection?: UsageCollectionSetup;
}

export interface StartPlugins {
Expand Down
12 changes: 3 additions & 9 deletions x-pack/plugins/siem/server/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,12 @@ import {
PluginInitializerContext,
Logger,
} from '../../../../src/core/server';
import {
PluginStartContract as AlertingStart,
PluginSetupContract as AlertingSetup,
} from '../../alerting/server';
import { PluginSetupContract as AlertingSetup } from '../../alerting/server';
import { SecurityPluginSetup as SecuritySetup } from '../../security/server';
import { PluginSetupContract as FeaturesSetup } from '../../features/server';
import { MlPluginSetup as MlSetup } from '../../ml/server';
import { EncryptedSavedObjectsPluginSetup as EncryptedSavedObjectsSetup } from '../../encrypted_saved_objects/server';
import { SpacesPluginSetup as SpacesSetup } from '../../spaces/server';
import { PluginStartContract as ActionsStart } from '../../actions/server';
import { LicensingPluginSetup } from '../../licensing/server';
import { initServer } from './init_server';
import { compose } from './lib/compose/kibana';
Expand Down Expand Up @@ -52,10 +48,8 @@ export interface SetupPlugins {
ml?: MlSetup;
}

export interface StartPlugins {
actions: ActionsStart;
alerting: AlertingStart;
}
// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface StartPlugins {}

// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface PluginSetup {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can optionally remove these two empty interfaces if you want and just do this below:

export class Plugin implements IPlugin<void, void, SetupPlugins, StartPlugins> {

And then remove the return {} you have in the start and setup to not return anything unless I'm missing something and we are returning empty objects for a purpose. But it looks like the contracts allow void for return types and we don't have anything useful to return at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrankHassanabad we return {} instead of undefined to allow consumers to distinguish between a disabled plugin and an enabled plugin with no contract. We first encountered this with our newsfeed integration, which resulted in #56236.

Expand Down