[ML] Moving to kibana capabilities #64057

jgowdyelastic · 2020-04-21T11:05:43Z

Changes the way the ml_capabilities are populated. Rather than being based on es privileges, they are now based on kibana's capabilities.

A licence level filter is applied using a capabilities switcher. This means for the most part, the standard kibana capabilities are correct and can be used by other plugins.
The only difference between the standard kibana capabilities and our ml_capabilities endpoint is the later also performs an upgrade mode check and will disable all admin capabilities if an upgrade is in progress.

Also renames all uses of "privileges" to "capabilities" in identifiers and file names as they are no longer based on es privileges.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-04-21T14:51:29Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2020-04-22T12:13:14Z

Pinging @elastic/ml-ui (:ml)

x-pack/plugins/ml/server/routes/apidoc.json

peteharverson · 2020-04-22T16:22:51Z

x-pack/plugins/ml/server/routes/job_service.ts

-      },
-    });
-    return resp.has_all_requested;
+    return mlCapabilities.canCreateJob;


If I'm logged in as a user without machine_learning_admin or machine_learning_user roles I still see the ML link in the sample data links on the Kibana Home page. Can this be hidden?

This should be fixed in a follow PR as it's not a trivial change.
At the point we initialise the sample datasets, we do not have the complete capabilities from kibana.
so the dataset initialisation will need to move, possibly to the plugin start function

Thinking about this some more, i'm not sure this is possible.
This sample dataset links are initialised once per kibana server setup. They are not based on request and so cannot be toggled based on user credentials.

Agreed, this doesn't currently seem possible with the way the sample data set links work. I've added it as an extra item to #64172 so we can follow up the extra changes that are required to the home and ml plugins.

peteharverson · 2020-04-22T16:28:25Z

x-pack/plugins/ml/common/types/capabilities.ts

+  // Filters
+  canGetFilters: false,
+  // Data Frame Analytics
+  canGetDataFrameAnalytics: false,


If I log in as a user with the machine_learning_user role. the clone item is showing for data frame analytics jobs:

This is a bug in master. I think it is outside the scope of this PR to fix here.
I've raised #64235 to cover it.

peteharverson

LGTM

walterra

Code LGTM

peteharverson

Tested latest edits with capabilities and switched and LGTM.

jgowdyelastic · 2020-04-23T15:17:10Z

retest

legrego

Reviewed the capabilities switcher, and did some light testing locally. From my perspective, this looks good!

legrego · 2020-04-23T19:59:25Z

x-pack/plugins/ml/server/lib/capabilities/capabilities_switcher.ts

+
+      return capabilities;
+    } catch (e) {
+      logger.debug('Error updating capabilities for ML based on licensing');


optional nit: you may want to include the exception in the log message so that failures are easier to diagnose:

Suggested change

logger.debug('Error updating capabilities for ML based on licensing');

logger.debug(`Error updating capabilities for ML based on licensing: ${e}`);

Fixed in 0eaa2a1

kibanamachine · 2020-04-24T10:33:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0eaa2a1

History

💚 Build #42839 succeeded fcd830d
💚 Build #42794 succeeded 23bbbe3ccc05eff3949d61d6c6cf3f22e6f7ea3c
💔 Build #42685 failed 2bab01e5b41cbb211fecf49b0bf94320a19dce67
💚 Build #42573 succeeded a08aabe9636a0465837d1cd64f44d0a1182f4c27
💚 Build #42483 succeeded 279e030f1c5538548e150aeacf1e003ba5e7e8e1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [ML] Moving to kibana capabilities * fixing types * renaming privilges * renaming privileges to capabilities * renaming resolvers * correcting admin capabilities * fixing includes * removing any types * renaming type * readding spaces * adding capabilities switcher * updating comment * removing unnecessary failing tests * adding error to log

…bana into ingest-node-pipeline/open-flyout-create-edit * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (116 commits) [Ingest Node Pipelines] More lenient treatment of on-failure value (elastic#64411) Report Deletion via UI- functional test (elastic#64031) Bump handlebars dependency from 4.5.3 to 4.7.6 (elastic#64402) [Uptime] Update TLS settings (elastic#64111) [alerting] removes usage of any throughout Alerting Services code (elastic#64161) [CANVAS] Moves notify to a canvas service (elastic#63268) [Canvas] Misc NP Stuff (elastic#63703) update apm index pattern (elastic#64232) Task/hostlist pagination (elastic#63722) [NP] Vega migration (elastic#63849) Move ensureDefaultIndexPattern into data plugin (elastic#63100) [Fleet] Fix agent status count to not include unenrolled agents (elastic#64106) Migrate graph_workspace saved object registration to Kibana platform (elastic#64157) Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern) (elastic#64184) [ML] EuiDataGrid ml/transform components. (elastic#63447) [ML] Moving to kibana capabilities (elastic#64057) Move input_control_vis into NP (elastic#63333) remove reference to local application service in graph (elastic#64288) KQL removes leading zero and breaks query (elastic#62748) [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193) ...

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 21, 2020

jgowdyelastic force-pushed the moving-to-kibana-capabilities branch from 0b350cd to 1af4ac8 Compare April 21, 2020 15:09

jgowdyelastic marked this pull request as ready for review April 22, 2020 12:11

jgowdyelastic requested a review from a team as a code owner April 22, 2020 12:11

jgowdyelastic requested review from peteharverson, walterra, darnautov and alvarezmelissa87 April 22, 2020 12:11

jgowdyelastic self-assigned this Apr 22, 2020

jgowdyelastic removed the request for review from darnautov April 22, 2020 12:12

jgowdyelastic added :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.8.0 v8.0.0 labels Apr 22, 2020

legrego self-requested a review April 22, 2020 15:12

peteharverson reviewed Apr 22, 2020

View reviewed changes

peteharverson approved these changes Apr 23, 2020

View reviewed changes

jgowdyelastic mentioned this pull request Apr 23, 2020

[ML] Integration with Kibana Spaces #64172

Closed

26 tasks

walterra approved these changes Apr 23, 2020

View reviewed changes

peteharverson approved these changes Apr 23, 2020

View reviewed changes

jgowdyelastic added 5 commits April 23, 2020 18:40

[ML] Moving to kibana capabilities

587d7eb

fixing types

8fa6014

renaming privilges

71e0e44

renaming privileges to capabilities

05e1fbe

renaming resolvers

0fd0bd7

jgowdyelastic added 8 commits April 23, 2020 18:40

correcting admin capabilities

293385c

fixing includes

ec9e9b8

removing any types

d41b155

renaming type

a14f7fd

readding spaces

bd9cc69

adding capabilities switcher

b1887a4

updating comment

02c18c8

removing unnecessary failing tests

fcd830d

jgowdyelastic force-pushed the moving-to-kibana-capabilities branch from 23bbbe3 to fcd830d Compare April 23, 2020 17:42

legrego approved these changes Apr 23, 2020

View reviewed changes

adding error to log

0eaa2a1

jgowdyelastic merged commit b3c7002 into elastic:master Apr 24, 2020

jgowdyelastic deleted the moving-to-kibana-capabilities branch April 24, 2020 11:08

jgowdyelastic mentioned this pull request Apr 24, 2020

[7.x] [ML] Moving to kibana capabilities (#64057) #64415

Merged

peteharverson mentioned this pull request Apr 28, 2020

[ML] Rename client side privileges to capabilities where applicable. #41874

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Moving to kibana capabilities #64057

[ML] Moving to kibana capabilities #64057

jgowdyelastic commented Apr 21, 2020 •

edited

Loading

elasticmachine commented Apr 21, 2020

elasticmachine commented Apr 22, 2020

peteharverson Apr 22, 2020

jgowdyelastic Apr 22, 2020 •

edited

Loading

jgowdyelastic Apr 22, 2020

peteharverson Apr 23, 2020

peteharverson Apr 22, 2020

jgowdyelastic Apr 22, 2020

peteharverson left a comment

walterra left a comment

peteharverson left a comment

jgowdyelastic commented Apr 23, 2020

legrego left a comment

legrego Apr 23, 2020

jgowdyelastic Apr 24, 2020

kibanamachine commented Apr 24, 2020

	logger.debug('Error updating capabilities for ML based on licensing');
	logger.debug(`Error updating capabilities for ML based on licensing: ${e}`);

[ML] Moving to kibana capabilities #64057

[ML] Moving to kibana capabilities #64057

Conversation

jgowdyelastic commented Apr 21, 2020 • edited Loading

Checklist

elasticmachine commented Apr 21, 2020

elasticmachine commented Apr 22, 2020

peteharverson Apr 22, 2020

Choose a reason for hiding this comment

jgowdyelastic Apr 22, 2020 • edited Loading

Choose a reason for hiding this comment

jgowdyelastic Apr 22, 2020

Choose a reason for hiding this comment

peteharverson Apr 23, 2020

Choose a reason for hiding this comment

peteharverson Apr 22, 2020

Choose a reason for hiding this comment

jgowdyelastic Apr 22, 2020

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

walterra left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

jgowdyelastic commented Apr 23, 2020

legrego left a comment

Choose a reason for hiding this comment

legrego Apr 23, 2020

Choose a reason for hiding this comment

jgowdyelastic Apr 24, 2020

Choose a reason for hiding this comment

kibanamachine commented Apr 24, 2020

💚 Build Succeeded

History

jgowdyelastic commented Apr 21, 2020 •

edited

Loading

jgowdyelastic Apr 22, 2020 •

edited

Loading