Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (#63489) #63662

Merged
merged 2 commits into from
Apr 16, 2020
Merged

[7.x] [alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (#63489) #63662

merged 2 commits into from
Apr 16, 2020

Commits on Apr 16, 2020

  1. [alerting] Adds an alertServices mock and uses it in siem, monitoring… 

    … and uptime (elastic#63489)

Work on elastic#61313 has revealed that we don't have amock for AlertServices, which creates coupling between us and any solution depending on us, which makes it harder to make changes in our own code.

This PR adds mocks and uses them in SIEM, Monitoring and Uptime, so that we can make future changes without having to change outside solutions.
    @gmmorris
    gmmorris committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    1fb1bd5 View commit details
    Browse the repository at this point in the history

  2. Update status_check.test.ts 

    updated snapshot
    @gmmorris
    gmmorris authored Apr 16, 2020
    Configuration menu
    Copy the full SHA
    50809bb View commit details
    Browse the repository at this point in the history