-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Service maps IE 11 bug fixes #63558
[APM] Service maps IE 11 bug fixes #63558
Conversation
…apes in IE 11 without icons
// https://stackoverflow.com/a/21825207 | ||
// | ||
// @ts-ignore `documentMode` is not recognized as a valid property of `document`. | ||
const isIE11 = !!window.MSInputMethodContext && !!document.documentMode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are using this in public/components/app/ServiceMap/icons.ts as well, should we put it in common and import it from there in both places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, now that I think about it, the flag in icons.ts
is now unnecessary since the iconForNode
function is never called now (from cytoscapeOptions.ts
. We can address this in another PR since this is already merged and backported now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice @ogupte!
@ogupte Not all that important, but if it's possible, can the service nodes be circles instead of squares to get closer to the real style? |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
…apes in IE 11 without icons (elastic#63558)
…apes in IE 11 without icons (elastic#63558)
… IE 11 without icons (#63558)
@formgeist: Unfortunately, in IE 11, drawing circles were producing errors. The bug seemed to show itself when it traversed specific segments of a draw path for certain shapes. Ellipses (including circles) and triangles (connection arrows) were among those shapes with the kind of drawing path that produced the error, but diamonds, and rectangles (including squares) seemed to render without issue. |
OK, thanks for looking into it though 👍 |
Closes #63113 by limiting service maps to only draw certain shapes in IE 11 without icons. Also fixes flex bugs in the popup details.
IE11 after fixes: