-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear cache when index pattern is deleted #63220
Clear cache when index pattern is deleted #63220
Conversation
…-10-clearCache-when-index-pattern-is-removed
Pinging @elastic/kibana-app (Team:KibanaApp) |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/dashboard·ts.Dashboard create dashboard buttonStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/dashboard·ts.Dashboard "after all" hook for "Open flight dashboard"Standard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/dashboard·ts.Dashboard create dashboard buttonStandard Out
Stack Trace
and 1 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
@kertal It seems like this PR overlaps with #63329 The test failure is happening because there is an additional delay introduced when switching to a new dashboard because the index pattern check now requires a network roundtrip. In my PR I moved this check to the app mounting to limit the number of times this has to happen. |
@flash1293 thanks a lot! this saves me a lot of time, was just wondering why this was failing. |
After syncing with @flash1293, closing it in favor of #63329 |
Summary
The cache containing the index patterns wasn't cleanup up, when an index pattern was removed in management. This caused problems in Discover: When the previously selected index pattern was deleted, there was an exception in Discover's rendering. This PR cleans up the cache when an index pattern is deleted in management, and furthermore, it triggers a refresh of the in the
ensureDefaultIndexPattern
function used by Discover/Virtualize/Dashboard.Fixes: #63180, #62269
Checklist