Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NP] Migrate logstash server side code to NP #63135

Merged
merged 16 commits into from
Apr 14, 2020
+959 −873
Merged

[NP] Migrate logstash server side code to NP #63135

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9432ada
convert api_integration test into TS
mshustov Apr 9, 2020
f6c9f01
create logstash NP plugin and move models
mshustov Apr 9, 2020
b8e114e
move common/constants to NP
mshustov Apr 9, 2020
fcca07d
type fetch all from scroll
mshustov Apr 9, 2020
877fa0f
move route declaration to NP
mshustov Apr 9, 2020
f3385ee
add licence checker wrapper
mshustov Apr 9, 2020
fa5fe8b
register logstash route handlers in NP
mshustov Apr 9, 2020
b703771
track logstash NP i18n
mshustov Apr 9, 2020
7cd1475
Merge branch 'master' into issue-60937-logstash-server
mshustov Apr 9, 2020
b40ef71
address shaunak comment
mshustov Apr 9, 2020
871b3d7
fix validation
mshustov Apr 9, 2020
f65fa3a
Merge branch 'master' into issue-60937-logstash-server
mshustov Apr 14, 2020
1d85d54
udpdate security tests since for new mock defaults
mshustov Apr 14, 2020
8d36307
Merge branch 'master' into issue-60937-logstash-server
mshustov Apr 14, 2020
de1a537
address Pierres comments
mshustov Apr 14, 2020
8344876
rename upgrade file route
mshustov Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions x-pack/plugins/security/common/licensing/license_service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,14 @@ describe('license features', function() {
expect(subscriptionHandler.mock.calls[1]).toMatchInlineSnapshot(`
Array [
Object {
"allowLogin": false,
"allowRbac": false,
"allowRoleDocumentLevelSecurity": false,
"allowRoleFieldLevelSecurity": false,
"allowSubFeaturePrivileges": false,
"showLinks": false,
"showLogin": false,
"showRoleMappingsManagement": false,
"allowLogin": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added default values to the getFeature mock led to these changes.

"allowRbac": true,
"allowRoleDocumentLevelSecurity": true,
"allowRoleFieldLevelSecurity": true,
"allowSubFeaturePrivileges": true,
"showLinks": true,
"showLogin": true,
"showRoleMappingsManagement": true,
},
]
`);
Expand Down