-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Add the ability for the ScopeResolver to escape "." #63133
Closed
jloleysens
wants to merge
1
commit into
elastic:master
from
jloleysens:console/fix/relative-resolve-with-dots
Closed
[Console] Add the ability for the ScopeResolver to escape "." #63133
jloleysens
wants to merge
1
commit into
elastic:master
from
jloleysens:console/fix/relative-resolve-with-dots
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "." means that we want to go a level deeper for the location of the relative autocomplete, something like ".a.b", but in a lot of cases "." is actually part of the internal endpoint name and so we need to respect that to resolve correctly.
jloleysens
added
Feature:Console
Dev Tools Console Feature
Feature:Dev Tools
v8.0.0
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
release_note:skip
Skip the PR/issue when compiling release notes
v7.8.0
labels
Apr 9, 2020
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/custom_elements·ts.Canvas app custom elements adds the custom element to the workpad when promptedStandard Out
Stack Trace
To update your PR or re-run it, just comment with: |
Closed in favor of #63444 for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Console
Dev Tools Console Feature
Feature:Dev Tools
release_note:skip
Skip the PR/issue when compiling release notes
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v7.8.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "." means that we want to go a level deeper for the location of the relative autocomplete, something like ".a.b", but in a lot of cases "." is actually part of the internal endpoint name and so we need to respect that to resolve correctly.
For instance
cluster.put_settings
(on master) does not resolve completions correctly for the "transient" key because of this. Bothpersistant
andtransient
should have the same completions available, test with the following snippet:Checklist
Delete any items that are not applicable to this PR.
For maintainers