Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.7][Discover] Wrap flaky with retry #63101

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

sulemanof
Copy link
Contributor

Summary

Wrap with retry to make sure angular did all rerenders.
This passed down 42 suites on FTR.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof sulemanof requested a review from dmlemeshko April 9, 2020 13:45
@sulemanof sulemanof marked this pull request as ready for review April 9, 2020 13:45
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 9, 2020
@sulemanof
Copy link
Contributor Author

Hope this will end up with #61714 🤞

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested with flaky-test-runner: 42 passed / 0 failed

@sulemanof sulemanof merged commit f699bd1 into elastic:7.7 Apr 9, 2020
@sulemanof sulemanof deleted the test/discover_retry branch April 9, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants