Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Data - Adding cloud reset password link to cloud instructions #62835

Merged
merged 10 commits into from
Apr 9, 2020
Merged

Add Data - Adding cloud reset password link to cloud instructions #62835

merged 10 commits into from
Apr 9, 2020

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Apr 7, 2020 •
edited
Loading

Changing the add data instructions to include a link allowing users to reset the password for their elastic user.

Before

Screen Shot 2020-04-07 at 11 02 55 AM

After

Screen Shot 2020-04-08 at 7 06 54 AM

This will only be shown when the xpack.cloud.resetPasswordUrl is set to a string. If xpack.cloud.resetPasswordUrl is not set to a string, it will revert to the prior behavior.

@kobelb kobelb added Feature:Add Data Add Data and sample data feature on Home v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 labels Apr 7, 2020
@kobelb
Copy link
Contributor Author

kobelb commented Apr 7, 2020

@VijayDoshi @gchaps any feedback on the text?

@andrew-moldovan in https://github.com/elastic/cloud/issues/54532 you mentioned an approach for Cloud to generate the url for a reset password link which would be shown in the login assistance. Can we use this same approach to set xpack.cloud.resetPasswordUrl starting in 7.7 for ESS?

@andrew-moldovan
Copy link

Yes there shouldn't be any difference

@kobelb
Copy link
Contributor Author

kobelb commented Apr 7, 2020

@elasticmachine merge upstream

@gchaps
Copy link
Contributor

gchaps commented Apr 7, 2020

How about this text:

Forgot your password? Reset in Cloud console.

where " Reset in Cloud console" is the link.

@andrew-moldovan is "Cloud console" the correct term?

@andrew-moldovan
Copy link

@gchaps to close the loop (since we talked about this in Slack), we should probably use Elastic Cloud UI

@gchaps
Copy link
Contributor

gchaps commented Apr 7, 2020

So then:

Forgot your password? Reset in Elastic Cloud UI.

@kobelb
Copy link
Contributor Author

kobelb commented Apr 7, 2020

Thanks @gchaps and @andrew-moldovan! Charges forthcoming.

@kobelb kobelb marked this pull request as ready for review April 7, 2020 23:35
@kobelb kobelb requested a review from flash1293 April 7, 2020 23:35
flash1293
flash1293 approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and the new link is shown in the right scenarios - LGTM. It's great a PR adding new functionality is removing three times as many lines as it adds 👍

@jowiho
Copy link

jowiho commented Apr 8, 2020

Nit: should it be "Forgot the password?" instead of "Forgot your password?" because just before we say "the password of the elastic user"?

@kobelb
Copy link
Contributor Author

kobelb commented Apr 8, 2020

@jowiho I deferred the decision on the text to Gail, who is our technical writer. I'd like to stick with her decision.

@gchaps
Copy link
Contributor

gchaps commented Apr 8, 2020 •
edited
Loading

@jowiho is correct. It should be "Forgot the password?"

@kobelb
Copy link
Contributor Author

kobelb commented Apr 8, 2020

@jowiho is correct. It should be "Forgot the password."

Changes coming :)

@jowiho
Copy link

jowiho commented Apr 8, 2020

@andrew-moldovan Is the name "Elastic Cloud UI" also suitable in other environments like ESSP or GovCloud?

@alexfrancoeur
Copy link

alexfrancoeur commented Apr 8, 2020 •
edited
Loading

To be consistent with other areas of Kibana that reference Elastic Cloud, I'd opt for removing UI from the text. If we're not using Elastic Cloud console, I don't think we necessarily need to reference the UI bit, it feels unnecessary. Being even more specific, we could say Reset the password for your Elastic Cloud deployment.

And if for some reason we really feel like we need to keep the UI reference, we'd need to consider updating the Elastic Cloud tutorial templates to be consistent.

image

@kobelb
Copy link
Contributor Author

kobelb commented Apr 8, 2020

To be consistent with other areas of Kibana that reference Elastic Cloud, I'd opt for removing UI from the text. If we're not using Elastic Cloud console, I don't think we necessarily need to reference the UI bit, it feels unnecessary

Good point. This change has been made.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kobelb kobelb merged commit 90d2b18 into elastic:master Apr 9, 2020
@kobelb kobelb deleted the home/cloud-reset-password branch April 9, 2020 14:43
This was referenced Apr 9, 2020
Merged
Merged
kobelb added a commit to kobelb/kibana that referenced this pull request Apr 9, 2020
@kobelb @elasticmachine
Add Data - Adding cloud reset password link to cloud instructions (el…
e127049 
…astic#62835)

* Adding cloud reset password link to cloud filebeat instructions

* Auditbeat gets the cool reset password link

* And the other beats instructions get the awesome password reset link

* Changing the i18n id to more closely match the on-prem cloud id

* Changing text for forgot password

* Removing now unused translations

* "Forgot your password" -> "Forgot the password"

* "Elastic Cloud UI" -> "Elastic Cloud"

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 9, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into es_ui_shared/…
bf57be0 
…chore/put-all-xjson-together

* 'master' of github.com:elastic/kibana:
  [EPM] Update UI copy to use `integration` (elastic#63077)
  [NP] Inline buildPointSeriesData and buildHierarchicalData dependencies (elastic#61575)
  [Maps] create NOT EXISTS filter for tooltip property with no value (elastic#62849)
  [Endpoint] Add link to Logs UI to the Host Details view (elastic#62852)
  [UI COPY] Fixes typo in max_shingle_size for search_as_you_type (elastic#63071)
  [APM] docs: add alerting examples for APM (elastic#62864)
  [EPM] Change PACKAGES_SAVED_OBJECT_TYPE id (elastic#62818)
  docs: fix rendering of bulleted list (elastic#62855)
  Exposed AddMessageVariables as separate component (elastic#63007)
  Add Data - Adding cloud reset password link to cloud instructions (elastic#62835)
  [ML] DF Analytics:  update memory estimate after adding exclude fields (elastic#62850)
  [Table Vis] Fix visualization overflow (elastic#62630)
  [Endpoint][EPM] Endpoint depending on ingest manager to initialize (elastic#62871)
  [Remote clusters] Fix flaky jest tests (elastic#58768)
  [Discover] Hide time picker when an indexpattern without timefield is selected (elastic#62134)
  Move search source parsing and serializing to data (elastic#59919)
  [ML] Functional tests - stabilize typing in mml input (elastic#63091)
  [data.search.aggs]: Clean up TimeBuckets implementation (elastic#62123)
  [ML] Functional transform tests - stabilize source selection (elastic#63087)
  add embed flag to saved object url as well (elastic#62926)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx
kobelb added a commit that referenced this pull request Apr 9, 2020
@kobelb @elasticmachine
Add Data - Adding cloud reset password link to cloud instructions (#6…
e168e67 
…2835) (#63126)

* Adding cloud reset password link to cloud filebeat instructions

* Auditbeat gets the cool reset password link

* And the other beats instructions get the awesome password reset link

* Changing the i18n id to more closely match the on-prem cloud id

* Changing text for forgot password

* Removing now unused translations

* "Forgot your password" -> "Forgot the password"

* "Elastic Cloud UI" -> "Elastic Cloud"

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kobelb added a commit that referenced this pull request Apr 9, 2020
@kobelb @elasticmachine
Add Data - Adding cloud reset password link to cloud instructions (#6…
c058453 
…2835) (#63127)

* Adding cloud reset password link to cloud filebeat instructions

* Auditbeat gets the cool reset password link

* And the other beats instructions get the awesome password reset link

* Changing the i18n id to more closely match the on-prem cloud id

* Changing text for forgot password

* Removing now unused translations

* "Forgot your password" -> "Forgot the password"

* "Elastic Cloud UI" -> "Elastic Cloud"

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
Feature:Add Data Add Data and sample data feature on Home release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kobelb @andrew-moldovan @gchaps @jowiho @alexfrancoeur @kibanamachine @flash1293 @elasticmachine