Embeddable clean up #62486
Merged
Embeddable clean up #62486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
stacey-gammon
added
v7.8.0
v8.0.0
release_note:skip
stacey-gammon
force-pushed
the
2020-04-03-embed-panel-helper
branch
from
6e4cc41
to
acf4e8c
Compare
stacey-gammon
force-pushed
the
2020-04-03-embed-panel-helper
branch
5 times, most recently
from
a982fb6
to
e268934
Compare
stacey-gammon
force-pushed
the
2020-04-03-embed-panel-helper
branch
from
e268934
to
581c21a
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Apr 6, 2020
stacey-gammon
added a commit
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking out some of the clean up and refactoring from #61749.
This PR:
EmbeddableStartfor users to useEmbeddablePanelwithout having to pass so many dependent services down.EmbeddablePanel, as I'll want access to the context menu triggers for the PR above.gutterSize="none"additions)hasMatchand I added a newcheck matchingbutton, to show how the parent can use output from its children. (cc @lizozom this was something you suggested awhile back, or at least changing the dynamic removal of children functionality).