Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] [Detection Engine] remove all unknowns from all rules table props #62327

Merged
merged 5 commits into from
Apr 3, 2020

Conversation

dhurley14
Copy link
Contributor

@dhurley14 dhurley14 commented Apr 2, 2020

Summary

Update types for AllRulesTables props.

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
- [ ] This was checked for cross-browser compatibility, including a check against IE11

For maintainers

@dhurley14 dhurley14 self-assigned this Apr 2, 2020
@dhurley14 dhurley14 added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 labels Apr 2, 2020
@dhurley14 dhurley14 marked this pull request as ready for review April 2, 2020 14:37
@dhurley14 dhurley14 requested a review from a team as a code owner April 2, 2020 14:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@dhurley14
Copy link
Contributor Author

@elasticmachine merge upstream

elasticmachine and others added 3 commits April 2, 2020 10:38
… properties we are not using in sorting, rename paginationMemo prop to pagination, remove null from rulesStatuses type as we are defaulting to empty array now
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left one small comment about maybe updating one of the types, that may be why the type checker is failing.

rulesStatuses: RuleStatusRowItemType[];
sorting: {
sort: {
field: 'enabled';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw in cases they used type EuiTableSortingType but then again I know we're limiting it to only sort the enabled field. Maybe something like EuiTableSortingType<Pick<Rule, 'enabled'>> (that might be off).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since EuiTableSortingType has sorting as optional, @XavierM mentioned that it might be better to explicitly type this field out, rather than using the eui type.

@yctercero yctercero self-requested a review April 2, 2020 19:41
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/infra/feature_controls/infrastructure_security·ts.InfraOps app feature controls infrastructure security global infrastructure read & logs read privileges infrastructure landing page with data context menu allows user to view logs

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:08:05]         └-: InfraOps app
[00:08:05]           └-> "before all" hook
[00:08:44]           └-: feature controls
[00:08:44]             └-> "before all" hook
[00:08:44]             └-: infrastructure security
[00:08:44]               └-> "before all" hook
[00:10:54]               └-: global infrastructure read & logs read privileges
[00:10:54]                 └-> "before all" hook
[00:10:54]                 └-> "before all" hook
[00:10:54]                   │ debg creating role global_infrastructure_logs_read_role
[00:10:54]                   │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1585857648346710564] added role [global_infrastructure_logs_read_role]
[00:10:54]                   │ debg creating user global_infrastructure_logs_read_user
[00:10:54]                   │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1585857648346710564] added user [global_infrastructure_logs_read_user]
[00:10:54]                   │ debg created user global_infrastructure_logs_read_user
[00:10:54]                   │ debg navigating to login url: http://localhost:6171/login
[00:10:54]                   │ debg Navigate to: http://localhost:6171/login
[00:10:55]                   │ debg ... sleep(700) start
[00:10:55]                   │ debg browser[INFO] http://localhost:6171/login?_t=1585860653056 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:10:55]                   │
[00:10:55]                   │ debg browser[INFO] http://localhost:6171/bundles/app/core/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:10:55]                   │ debg ... sleep(700) end
[00:10:55]                   │ debg returned from get, calling refresh
[00:10:56]                   │ debg browser[INFO] http://localhost:6171/login?_t=1585860653056 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:10:56]                   │
[00:10:56]                   │ debg browser[INFO] http://localhost:6171/bundles/app/core/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:10:56]                   │ debg currentUrl = http://localhost:6171/login
[00:10:56]                   │          appUrl = http://localhost:6171/login
[00:10:56]                   │ debg TestSubjects.find(kibanaChrome)
[00:10:56]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:11:03]                   │ debg browser[INFO] http://localhost:6171/bundles/plugin/data/data.plugin.js 96:139630 "INFO: 2020-04-02T20:51:01Z
[00:11:03]                   │        Adding connection to http://localhost:6171/elasticsearch
[00:11:03]                   │
[00:11:03]                   │      "
[00:11:03]                   │ debg ... sleep(501) start
[00:11:03]                   │ debg ... sleep(501) end
[00:11:03]                   │ debg in navigateTo url = http://localhost:6171/login
[00:11:03]                   │ debg TestSubjects.exists(statusPageContainer)
[00:11:03]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:11:06]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:11:06]                   │ debg TestSubjects.setValue(loginUsername, global_infrastructure_logs_read_user)
[00:11:06]                   │ debg TestSubjects.click(loginUsername)
[00:11:06]                   │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:11:06]                   │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:11:07]                   │ debg TestSubjects.setValue(loginPassword, global_infrastructure_logs_read_user-password)
[00:11:07]                   │ debg TestSubjects.click(loginPassword)
[00:11:07]                   │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:11:07]                   │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:11:08]                   │ debg TestSubjects.click(loginSubmit)
[00:11:08]                   │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:11:08]                   │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:11:08]                   │ debg Waiting up to 20000ms for logout button visible...
[00:11:08]                   │ debg TestSubjects.exists(userMenuButton)
[00:11:08]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:11:10]                   │ debg browser[INFO] http://localhost:6171/app/kibana 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:11:10]                   │
[00:11:10]                   │ debg browser[INFO] http://localhost:6171/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:11:10]                   │ debg --- retry.tryForTime error: [data-test-subj="userMenuButton"] is not displayed
[00:11:11]                   │ debg TestSubjects.exists(userMenuButton)
[00:11:11]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:11:18]                   │ debg browser[INFO] http://localhost:6171/bundles/plugin/data/data.plugin.js 96:139630 "INFO: 2020-04-02T20:51:15Z
[00:11:18]                   │        Adding connection to http://localhost:6171/elasticsearch
[00:11:18]                   │
[00:11:18]                   │      "
[00:11:18]                   │ debg --- retry.tryForTime error: [data-test-subj="userMenuButton"] is not displayed
[00:11:19]                   │ debg TestSubjects.exists(userMenuButton)
[00:11:19]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:11:21]                   │ debg TestSubjects.exists(userMenu)
[00:11:21]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:11:21]                   │ERROR browser[SEVERE] http://localhost:6171/api/saved_objects/_bulk_get - Failed to load resource: the server responded with a status of 403 (Forbidden)
[00:11:21]                   │ debg browser[INFO] http://localhost:6171/bundles/commons.bundle.js 2:4317179 "Detected an unhandled Promise rejection.
[00:11:21]                   │      Error: Forbidden"
[00:11:21]                   │ERROR browser[SEVERE] http://localhost:6171/bundles/commons.bundle.js 2:4351736 
[00:11:24]                   │ debg --- retry.tryForTime error: [data-test-subj="userMenu"] is not displayed
[00:11:24]                   │ debg TestSubjects.click(userMenuButton)
[00:11:24]                   │ debg Find.clickByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:11:24]                   │ debg Find.findByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:11:24]                   │ debg Waiting up to 20000ms for user menu opened...
[00:11:24]                   │ debg TestSubjects.exists(userMenu)
[00:11:24]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:11:24]                   │ debg TestSubjects.exists(userMenu > logoutLink)
[00:11:24]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"] [data-test-subj="logoutLink"]') with timeout=2500
[00:11:24]                 └-: infrastructure landing page with data
[00:11:24]                   └-> "before all" hook
[00:11:24]                   └-> "before all" hook
[00:11:24]                     │ info [infra/metrics_and_logs] Loading "mappings.json"
[00:11:25]                     │ info [infra/metrics_and_logs] Loading "data.json.gz"
[00:11:25]                     │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585857648346710564] [metricbeat-7.0.0-alpha1-2018.10.17] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:11:25]                     │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585857648346710564] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[metricbeat-7.0.0-alpha1-2018.10.17][0]]])." previous.health="YELLOW" reason="shards started [[metricbeat-7.0.0-alpha1-2018.10.17][0]]"
[00:11:25]                     │ info [infra/metrics_and_logs] Created index "metricbeat-7.0.0-alpha1-2018.10.17"
[00:11:25]                     │ debg [infra/metrics_and_logs] "metricbeat-7.0.0-alpha1-2018.10.17" settings {"index":{"codec":"best_compression","mapping":{"total_fields":{"limit":"10000"}},"number_of_replicas":"0","number_of_shards":"1","query":{"default_field":["beat.name","beat.hostname","beat.timezone","beat.version","tags","error.message","error.type","meta.cloud.provider","meta.cloud.instance_id","meta.cloud.instance_name","meta.cloud.machine_type","meta.cloud.availability_zone","meta.cloud.project_id","meta.cloud.region","docker.container.id","docker.container.image","docker.container.name","host.name","host.id","host.architecture","host.os.platform","host.os.version","host.os.family","host.mac","kubernetes.pod.name","kubernetes.pod.uid","kubernetes.namespace","kubernetes.node.name","kubernetes.container.name","kubernetes.container.image","metricset.module","metricset.name","metricset.host","metricset.namespace","type","service.name","aerospike.namespace.name","aerospike.namespace.node.host","aerospike.namespace.node.name","apache.status.hostname","ceph.cluster_health.overall_status","ceph.cluster_health.timechecks.round.status","ceph.monitor_health.health","ceph.monitor_health.name","ceph.osd_df.name","ceph.osd_df.device_class","ceph.osd_tree.name","ceph.osd_tree.type","ceph.osd_tree.children","ceph.osd_tree.status","ceph.osd_tree.device_class","ceph.osd_tree.father","ceph.pool_disk.name","couchbase.bucket.name","couchbase.bucket.type","couchbase.node.hostname","docker.container.command","docker.container.status","docker.container.ip_addresses","docker.healthcheck.status","docker.healthcheck.event.output","docker.image.id.current","docker.image.id.parent","docker.info.id","docker.network.interface","elasticsearch.cluster.name","elasticsearch.cluster.id","elasticsearch.cluster.state.id","elasticsearch.index.name","elasticsearch.node.name","elasticsearch.node.version","elasticsearch.node.jvm.version","elasticsearch.cluster.pending_task.source","elasticsearch.shard.state","etcd.leader.leader","etcd.self.id","etcd.self.leaderinfo.leader","etcd.self.leaderinfo.starttime","etcd.self.leaderinfo.uptime","etcd.self.name","etcd.self.starttime","etcd.self.state","golang.expvar.cmdline","golang.heap.cmdline","graphite.server.example","haproxy.stat.status","haproxy.stat.service_name","haproxy.stat.check.status","haproxy.stat.check.health.last","haproxy.stat.proxy.name","http.request.method","http.request.body","http.response.code","http.response.phrase","http.response.body","kafka.consumergroup.broker.address","kafka.consumergroup.id","kafka.consumergroup.topic","kafka.consumergroup.meta","kafka.consumergroup.client.id","kafka.consumergroup.client.host","kafka.consumergroup.client.member_id","kafka.partition.topic.name","kafka.partition.broker.address","kibana.stats.cluster_uuid","kibana.stats.name","kibana.stats.uuid","kibana.stats.version.number","kibana.stats.status.overall.state","kibana.status.name","kibana.status.uuid","kibana.status.version.number","kibana.status.status.overall.state","kubernetes.apiserver.request.client","kubernetes.apiserver.request.resource","kubernetes.apiserver.request.subresource","kubernetes.apiserver.request.scope","kubernetes.apiserver.request.verb","kubernetes.event.message","kubernetes.event.reason","kubernetes.event.type","kubernetes.event.metadata.name","kubernetes.event.metadata.namespace","kubernetes.event.metadata.resource_version","kubernetes.event.metadata.uid","kubernetes.event.metadata.self_link","kubernetes.event.involved_object.api_version","kubernetes.event.involved_object.kind","kubernetes.event.involved_object.name","kubernetes.event.involved_object.resource_version","kubernetes.event.involved_object.uid","kubernetes.container.id","kubernetes.container.status.phase","kubernetes.container.status.reason","kubernetes.deployment.name","kubernetes.node.status.ready","kubernetes.pod.status.phase","kubernetes.pod.status.ready","kubernetes.pod.status.scheduled","kubernetes.replicaset.name","kubernetes.statefulset.name","kubernetes.system.container","kubernetes.volume.name","kvm.dommemstat.stat.name","kvm.dommemstat.name","logstash.node.host","logstash.node.version","logstash.node.jvm.version","mongodb.collstats.db","mongodb.collstats.collection","mongodb.collstats.name","mongodb.dbstats.db","mongodb.status.version","mongodb.status.storage_engine.name","mysql.galera_status.cluster.status","mysql.galera_status.connected","mysql.galera_status.evs.evict","mysql.galera_status.evs.state","mysql.galera_status.local.state","mysql.galera_status.ready","nginx.stubstatus.hostname","php_fpm.pool.name","php_fpm.pool.process_manager","postgresql.activity.database.name","postgresql.activity.user.name","postgresql.activity.application_name","postgresql.activity.client.address","postgresql.activity.client.hostname","postgresql.activity.state","postgresql.activity.query","postgresql.database.name","postgresql.statement.query.text","rabbitmq.connection.name","rabbitmq.connection.vhost","rabbitmq.connection.user","rabbitmq.connection.node","rabbitmq.connection.type","rabbitmq.connection.host","rabbitmq.connection.peer.host","rabbitmq.exchange.name","rabbitmq.exchange.vhost","rabbitmq.exchange.user","rabbitmq.node.name","rabbitmq.node.type","rabbitmq.queue.name","rabbitmq.queue.vhost","rabbitmq.queue.node","rabbitmq.queue.state","redis.info.memory.max.policy","redis.info.memory.allocator","redis.info.persistence.rdb.bgsave.last_status","redis.info.persistence.aof.bgrewrite.last_status","redis.info.persistence.aof.write.last_status","redis.info.replication.role","redis.info.server.version","redis.info.server.git_sha1","redis.info.server.git_dirty","redis.info.server.build_id","redis.info.server.mode","redis.info.server.os","redis.info.server.arch_bits","redis.info.server.multiplexing_api","redis.info.server.gcc_version","redis.info.server.run_id","redis.info.server.config_file","redis.keyspace.id","system.diskio.name","system.diskio.serial_number","system.filesystem.device_name","system.filesystem.type","system.filesystem.mount_point","system.network.name","system.process.name","system.process.state","system.process.cmdline","system.process.username","system.process.cwd","system.process.cgroup.id","system.process.cgroup.path","system.process.cgroup.cpu.id","system.process.cgroup.cpu.path","system.process.cgroup.cpuacct.id","system.process.cgroup.cpuacct.path","system.process.cgroup.memory.id","system.process.cgroup.memory.path","system.process.cgroup.blkio.id","system.process.cgroup.blkio.path","system.raid.name","system.raid.activity_state","system.socket.direction","system.socket.family","system.socket.remote.host","system.socket.remote.etld_plus_one","system.socket.remote.host_error","system.socket.process.command","system.socket.process.cmdline","system.socket.process.exe","system.socket.user.name","uwsgi.status.worker.status","uwsgi.status.worker.rss","vsphere.datastore.name","vsphere.datastore.fstype","vsphere.host.name","vsphere.host.network_names","vsphere.virtualmachine.host","vsphere.virtualmachine.name","vsphere.virtualmachine.network_names","windows.service.id","windows.service.name","windows.service.display_name","windows.service.start_type","windows.service.state","windows.service.exit_code","zookeeper.mntr.hostname","zookeeper.mntr.server_state","zookeeper.mntr.version","fields.*"]},"refresh_interval":"5s"}}
[00:11:25]                     │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585857648346710564] [filebeat-7.0.0-alpha1-2018.10.17] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:11:25]                     │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1585857648346710564] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[filebeat-7.0.0-alpha1-2018.10.17][0]]])." previous.health="YELLOW" reason="shards started [[filebeat-7.0.0-alpha1-2018.10.17][0]]"
[00:11:25]                     │ info [infra/metrics_and_logs] Created index "filebeat-7.0.0-alpha1-2018.10.17"
[00:11:25]                     │ debg [infra/metrics_and_logs] "filebeat-7.0.0-alpha1-2018.10.17" settings {"index":{"codec":"best_compression","mapping":{"total_fields":{"limit":"10000"}},"number_of_replicas":"0","number_of_shards":"1","query":{"default_field":["beat.name","beat.hostname","beat.timezone","beat.version","tags","error.message","error.type","meta.cloud.provider","meta.cloud.instance_id","meta.cloud.instance_name","meta.cloud.machine_type","meta.cloud.availability_zone","meta.cloud.project_id","meta.cloud.region","docker.container.id","docker.container.image","docker.container.name","host.name","host.id","host.architecture","host.os.platform","host.os.version","host.os.family","host.mac","kubernetes.pod.name","kubernetes.pod.uid","kubernetes.namespace","kubernetes.node.name","kubernetes.container.name","kubernetes.container.image","source","message","stream","prospector.type","input.type","read_timestamp","fileset.module","fileset.name","syslog.severity_label","syslog.facility_label","process.program","service.name","log.level","apache2.access.remote_ip","apache2.access.user_name","apache2.access.method","apache2.access.url","apache2.access.http_version","apache2.access.referrer","apache2.access.agent","apache2.access.user_agent.device","apache2.access.user_agent.patch","apache2.access.user_agent.name","apache2.access.user_agent.os","apache2.access.user_agent.os_name","apache2.access.geoip.continent_name","apache2.access.geoip.country_iso_code","apache2.access.geoip.region_name","apache2.access.geoip.city_name","apache2.error.level","apache2.error.client","apache2.error.message","apache2.error.module","auditd.log.record_type","auditd.log.old_auid","auditd.log.new_auid","auditd.log.old_ses","auditd.log.new_ses","auditd.log.acct","auditd.log.pid","auditd.log.ppid","auditd.log.items","auditd.log.item","auditd.log.a0","auditd.log.res","auditd.log.geoip.continent_name","auditd.log.geoip.city_name","auditd.log.geoip.region_name","auditd.log.geoip.country_iso_code","elasticsearch.audit.node_name","elasticsearch.audit.layer","elasticsearch.audit.event_type","elasticsearch.audit.origin_type","elasticsearch.audit.principal","elasticsearch.audit.action","elasticsearch.audit.uri","elasticsearch.audit.request","elasticsearch.audit.request_body","elasticsearch.gc.tags","elasticsearch.server.component","elasticsearch.slowlog.loglevel","elasticsearch.slowlog.logger","elasticsearch.slowlog.node_name","elasticsearch.slowlog.index_name","elasticsearch.slowlog.shard_id","elasticsearch.slowlog.took","elasticsearch.slowlog.types","elasticsearch.slowlog.stats","elasticsearch.slowlog.search_type","elasticsearch.slowlog.source_query","elasticsearch.slowlog.extra_source","elasticsearch.slowlog.took_millis","elasticsearch.slowlog.total_hits","elasticsearch.slowlog.total_shards","icinga.debug.facility","icinga.debug.severity","icinga.debug.message","icinga.main.facility","icinga.main.severity","icinga.main.message","icinga.startup.facility","icinga.startup.severity","icinga.startup.message","iis.access.server_ip","iis.access.method","iis.access.url","iis.access.query_string","iis.access.user_name","iis.access.remote_ip","iis.access.referrer","iis.access.site_name","iis.access.server_name","iis.access.http_version","iis.access.cookie","iis.access.hostname","iis.access.agent","iis.access.user_agent.device","iis.access.user_agent.patch","iis.access.user_agent.name","iis.access.user_agent.os","iis.access.user_agent.os_name","iis.access.geoip.continent_name","iis.access.geoip.country_iso_code","iis.access.geoip.region_name","iis.access.geoip.city_name","iis.error.remote_ip","iis.error.server_ip","iis.error.http_version","iis.error.method","iis.error.url","iis.error.reason_phrase","iis.error.queue_name","iis.error.geoip.continent_name","iis.error.geoip.country_iso_code","iis.error.geoip.region_name","iis.error.geoip.city_name","kafka.log.timestamp","kafka.log.level","kafka.log.message","kafka.log.component","kafka.log.class","kafka.log.trace.class","kafka.log.trace.message","kafka.log.trace.full","kibana.log.tags","kibana.log.state","logstash.log.message","logstash.log.level","logstash.log.module","logstash.log.thread","logstash.slowlog.message","logstash.slowlog.level","logstash.slowlog.module","logstash.slowlog.thread","logstash.slowlog.event","logstash.slowlog.plugin_name","logstash.slowlog.plugin_type","logstash.slowlog.plugin_params","mongodb.log.severity","mongodb.log.component","mongodb.log.context","mongodb.log.message","mysql.error.timestamp","mysql.error.level","mysql.error.message","mysql.slowlog.user","mysql.slowlog.host","mysql.slowlog.ip","mysql.slowlog.query","nginx.access.remote_ip","nginx.access.user_name","nginx.access.method","nginx.access.url","nginx.access.http_version","nginx.access.referrer","nginx.access.agent","nginx.access.user_agent.device","nginx.access.user_agent.patch","nginx.access.user_agent.name","nginx.access.user_agent.os","nginx.access.user_agent.os_name","nginx.access.geoip.continent_name","nginx.access.geoip.country_iso_code","nginx.access.geoip.region_name","nginx.access.geoip.city_name","nginx.error.level","nginx.error.message","osquery.result.name","osquery.result.action","osquery.result.host_identifier","osquery.result.calendar_time","postgresql.log.timestamp","postgresql.log.timezone","postgresql.log.user","postgresql.log.database","postgresql.log.level","postgresql.log.query","postgresql.log.message","redis.log.role","redis.log.level","redis.log.message","redis.slowlog.cmd","redis.slowlog.key","redis.slowlog.args","system.auth.timestamp","system.auth.hostname","system.auth.program","system.auth.message","system.auth.user","system.auth.ssh.event","system.auth.ssh.method","system.auth.ssh.signature","system.auth.ssh.geoip.continent_name","system.auth.ssh.geoip.city_name","system.auth.ssh.geoip.region_name","system.auth.ssh.geoip.country_iso_code","system.auth.sudo.error","system.auth.sudo.tty","system.auth.sudo.pwd","system.auth.sudo.user","system.auth.sudo.command","system.auth.useradd.name","system.auth.useradd.home","system.auth.useradd.shell","system.auth.groupadd.name","system.syslog.timestamp","system.syslog.hostname","system.syslog.program","system.syslog.pid","system.syslog.message","traefik.access.remote_ip","traefik.access.user_name","traefik.access.method","traefik.access.url","traefik.access.http_version","traefik.access.referrer","traefik.access.agent","traefik.access.user_agent.device","traefik.access.user_agent.patch","traefik.access.user_agent.name","traefik.access.user_agent.os","traefik.access.user_agent.os_name","traefik.access.geoip.continent_name","traefik.access.geoip.country_iso_code","traefik.access.geoip.region_name","traefik.access.geoip.city_name","traefik.access.frontend_name","traefik.access.backend_url","fields.*"]},"refresh_interval":"5s"}}
[00:11:33]                     │ info [infra/metrics_and_logs] Indexed 11063 docs into "metricbeat-7.0.0-alpha1-2018.10.17"
[00:11:33]                     │ info [infra/metrics_and_logs] Indexed 1632 docs into "filebeat-7.0.0-alpha1-2018.10.17"
[00:11:33]                   └-> context menu allows user to view logs
[00:11:33]                     └-> "before each" hook: global before each
[00:11:33]                     │ debg navigateToActualUrl http://localhost:6171/app/metrics
[00:11:34]                     │ debg browser[INFO] http://localhost:6171/app/metrics?_t=1585860692037 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:11:34]                     │
[00:11:34]                     │ debg browser[INFO] http://localhost:6171/bundles/app/core/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:11:34]                     │ debg Find.findByCssSelector('[data-test-subj="waffleDatePicker"] .euiDatePicker.euiFieldText') with timeout=10000
[00:11:44]                     │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/InfraOps app feature controls infrastructure security global infrastructure read _ logs read privileges infrastructure landing page with data context menu allows user to view logs.png"
[00:11:44]                     │ debg browser[INFO] http://localhost:6171/bundles/plugin/data/data.plugin.js 96:139630 "INFO: 2020-04-02T20:51:40Z
[00:11:44]                     │        Adding connection to http://localhost:6171/elasticsearch
[00:11:44]                     │
[00:11:44]                     │      "
[00:11:44]                     │ERROR browser[SEVERE] http://localhost:6171/api/saved_objects/_bulk_get - Failed to load resource: the server responded with a status of 403 (Forbidden)
[00:11:44]                     │ debg browser[INFO] http://localhost:6171/bundles/commons.bundle.js 2:4317179 "Detected an unhandled Promise rejection.
[00:11:44]                     │      Error: Forbidden"
[00:11:44]                     │ERROR browser[SEVERE] http://localhost:6171/bundles/commons.bundle.js 2:4351736 
[00:11:44]                     │ info Current URL is: http://localhost:6171/app/metrics/inventory
[00:11:45]                     │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/InfraOps app feature controls infrastructure security global infrastructure read _ logs read privileges infrastructure landing page with data context menu allows user to view logs.html
[00:11:45]                     └- ✖ fail: "InfraOps app feature controls infrastructure security global infrastructure read & logs read privileges infrastructure landing page with data context menu allows user to view logs"
[00:11:45]                     │

Stack Trace

{ TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="waffleDatePicker"] .euiDatePicker.euiFieldText)
Wait timed out after 10066ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError', remoteStacktrace: '' }

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhurley14 dhurley14 merged commit 96ac8de into elastic:master Apr 3, 2020
@dhurley14 dhurley14 deleted the fix-monitoring-types branch April 3, 2020 21:35
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Apr 3, 2020
…tic#62327)

* remove all unknowns from all rules table props

* update sorting property type remove optional, also remove unnecessary properties we are not using in sorting, rename paginationMemo prop to pagination, remove null from rulesStatuses type as we are defaulting to empty array now

* fixes type mismatch for sorting and rulesStatuses

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 6, 2020
…into event-log/query-support

* 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits)
  [jenkins] refer to sizes in most pipeline code (elastic#62082)
  skip flaky suite (elastic#60470)
  [Discover] Fix flaky FT in field visualize (elastic#62418)
  [ML] Data Frame Analytics: Fix feature importance (elastic#61761)
  [Reporting] Use a shim for server config (elastic#62086)
  [Reporting] Fix reporting for non-default spaces (elastic#62226)
  Fix bug that coerced empty scaled float value to 0 (elastic#62251)
  [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446)
  [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507)
  Reporting/bug more blacklisted headers (elastic#62389)
  [SIEM] Prevent undefined behavior in our ML popover (elastic#62498)
  [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327)
  base changes for active/current node styling (elastic#62007)
  [kbn/ui-shared-deps] expand and split (elastic#62364)
  [ML] DF Analytics - ensure destination index pattern created (elastic#62450)
  Mark rule run as failure if there was an error (elastic#62383)
  Add docs for metric explorer alerts (elastic#62314)
  skip flaky suite (elastic#62281)
  [SIEM][Detection Engine] Fixes export of single rule and the icons
  fixes flakiness (elastic#62406)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants