Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fetch service map data if no license #62071

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Don't fetch service map data if no license #62071

merged 1 commit into from
Apr 1, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Mar 31, 2020

Fixes #61994

@smith smith requested a review from a team as a code owner March 31, 2020 20:36
@smith smith added v7.7.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 31, 2020
ogupte
ogupte approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 433d06f into elastic:master Apr 1, 2020
@smith smith deleted the nls/no-fetch-license branch April 1, 2020 19:22
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 62071 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 3, 2020
smith added a commit to smith/kibana that referenced this pull request Apr 6, 2020
@smith
Don't fetch service map data if no license (elastic#62071)
246e223 
Fixes elastic#61994
@smith smith mentioned this pull request Apr 6, 2020
Merged
smith added a commit to smith/kibana that referenced this pull request Apr 6, 2020
@smith
Don't fetch service map data if no license (elastic#62071)
7e0b2a6 
Fixes elastic#61994
@smith smith mentioned this pull request Apr 6, 2020
Merged
smith added a commit that referenced this pull request Apr 7, 2020
@smith
Don't fetch service map data if no license (#62071) (#62716)
03abbde 
Fixes #61994
smith added a commit that referenced this pull request Apr 7, 2020
@smith
Don't fetch service map data if no license (#62071) (#62717)
0fbf560 
Fixes #61994
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Error when open service map with basic license
3 participants
@smith @kibanamachine @ogupte